-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healthcheck notifications #1031
Conversation
I can't really read or review JS. I can try running it and clicking here and there. Would that be ok @tmasternak ? |
@SzymonPobiega sounds good. |
...ervicePulse.Host/app/modules/configuration/js/notifications/emailnotifications.controller.js
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/app/modules/configuration/views/notificationsemailmodal.html
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/app/modules/configuration/views/notificationsemailmodal.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Marbach <daniel.marbach@particular.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not terribly confident reviewing js but it looks good to me.
It might make sense to have the test connection button on the edit. That requires a bit of a re-architectue of the back-end, and it's probably not worth it for this first release.
Does ServicePulse have a minim required ServiceControl version, because this will increase it. What happens in this UI with an older version of ServiceControl?
I had a chat with Sergio about that and we decided that the current location is good enough
It looks that this is the current minimum which looks quite outdated. I tried to spike an approach in which the tab hides when the ServiceControl version is less than 4.17 (we already have code to do version parsing etc.). That being said there seems to be more re-work needed around Angular controllers for the configuration section. I propose to create a separate issue for that. |
This PR introduces health check notification capabilities to ServicePulse. Notifications can be delivered as emails.