Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck notifications #1031

Merged
merged 24 commits into from
May 6, 2021
Merged

Healthcheck notifications #1031

merged 24 commits into from
May 6, 2021

Conversation

tmasternak
Copy link
Member

@tmasternak tmasternak commented Apr 12, 2021

This PR introduces health check notification capabilities to ServicePulse. Notifications can be delivered as emails.

@tmasternak tmasternak changed the title Custom check alerting configuration tab Healthcheck notifications Apr 22, 2021
@tmasternak tmasternak marked this pull request as ready for review April 22, 2021 12:58
@SzymonPobiega
Copy link
Member

I can't really read or review JS. I can try running it and clicking here and there. Would that be ok @tmasternak ?

@tmasternak
Copy link
Member Author

@SzymonPobiega sounds good.

@SzymonPobiega
Copy link
Member

Looks good. The only thing that looks a bit odd is this:

image

but I am not sure we can do anything with it. Certainly not with my CSS/HTML skills 😂

Copy link
Member

@mikeminutillo mikeminutillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not terribly confident reviewing js but it looks good to me.

It might make sense to have the test connection button on the edit. That requires a bit of a re-architectue of the back-end, and it's probably not worth it for this first release.

Does ServicePulse have a minim required ServiceControl version, because this will increase it. What happens in this UI with an older version of ServiceControl?

@tmasternak
Copy link
Member Author

It might make sense to have the test connection button on the edit. That requires a bit of a re-architectue of the back-end, and it's probably not worth it for this first release.

I had a chat with Sergio about that and we decided that the current location is good enough

Does ServicePulse have a minim required ServiceControl version because this will increase it. What happens in this UI with an older version of ServiceControl?

It looks that this is the current minimum which looks quite outdated. I tried to spike an approach in which the tab hides when the ServiceControl version is less than 4.17 (we already have code to do version parsing etc.). That being said there seems to be more re-work needed around Angular controllers for the configuration section. I propose to create a separate issue for that.

@tmasternak tmasternak merged commit 3ab53d9 into master May 6, 2021
@tmasternak tmasternak deleted the cutom-checks-alerting branch May 6, 2021 09:55
@tmasternak tmasternak added this to the 1.29.0 milestone May 6, 2021
@tmasternak tmasternak added the Type: Feature Type: Feature label May 6, 2021
WilliamBZA pushed a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants