Strip comments from message body payloads #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
approved these changes
Apr 26, 2022
| method: 'GET', | ||
| transformResponse: function(defaults, transform) { | ||
| // Remove any comments from the body before deserializing | ||
| return defaults.replace(/\\"|"(?:\\"|[^"])*"|(\/\/.*|\/\*[\s\S]*?\*\/)/g, function (m, g) { return g ? "" : m }); |
WilliamBZA
added a commit
that referenced
this pull request
Feb 17, 2023
Strip comments from message body payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Removes comments of the style:
// comment/* comment */from the body of messages that are received from ServiceControl so that they can be rendered correctly.
This will also remove comments from XML messages as they are sent to SP as JSON anyway and will be subject to the same problems.
I don't know that this is testable given the reliance on angularjs as the
$httpwrapper.