Migrate events view to Vue #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilBastian
reviewed
Jan 11, 2024
mikeminutillo
force-pushed
the
migrate-eventlog-vue
branch
from
4425353
to
6248fee
Compare
johnsimons
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
@mikeminutillo really nice work on the DataView
A few observations:
- We have "autorefresh" lists, but IMO, they do make sense for the Dashboard (last 10 items) but for pageable lists, IMHO it feels weird, thoughts?
- To me the organisation of the code feels a bit odd, I would add a subfolder in the views folder, named "events" and add to it the EventItemShort and EventLogItem. And also move Eventsview into it.
To me "components" are for reusable things that are not really specific to the app that are shared everywhere
johnsimons
reviewed
Jan 30, 2024
mikeminutillo
force-pushed
the
migrate-eventlog-vue
branch
from
8195750
to
0e46c7d
Compare
PhilBastian
reviewed
Feb 1, 2024
johnsimons
reviewed
Feb 2, 2024
mikeminutillo
changed the title
PhilBastian
approved these changes
Feb 5, 2024
Should this not be a template? Should there be a checkbox to allow the user to turn auto-refresh off.
Vue requires components to be multi-word
in and of have meanings in js so better to use of which is what you would use outside of vue
mikeminutillo
force-pushed
the
migrate-eventlog-vue
branch
from
6037708
to
b98ff75
Compare
This was referenced Feb 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
Fixes #1559