Added drag and drop to Failed Message Flow Diagram nodes #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…children belonging to incorrect duplicated parent
johnsimons
approved these changes
Jan 29, 2024
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
| } | ||
| elements.value = [...constructNodes(mappedMessages), ...constructEdges(mappedMessages)]; | ||
| //TODO: if doing fitView on next Vue onUpdated() then it doesn't appear the elements | ||
| // are actually drawn yet. See if we can determine a better event to use this on rather than relying on setTimeout |
There was a problem hiding this comment.
I couldn't work out a nice solution (the documentation for Vue-flow isn't the greatest). This was the best I could come up with, but left the TODO for future reference
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
Outdated
Show resolved
Hide resolved
…onflict # Conflicts: # src/ServicePulse.Host/vue/package-lock.json # src/ServicePulse.Host/vue/src/components/failedmessages/FlowDiagram.vue
PhilBastian
added
Type: Refactoring
PhilBastian
added
Type: Improvement
mikeminutillo
changed the title
mikeminutillo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated flow diagram from AngularJS directly used d3 for DOM drawing of SVG elements.
This PR changes to use a Vue-specific flow diagram library, allowing for using templates rather than HTML string concatenation.
This also fixes an issue where the diagram wouldn't update the UI reactively as the node elements changed.
This PR also enables the use of drag and drop on nodes for user-managed layout.