Adding Usage Report area #1746

johnsimons · 2024-02-26T23:38:10Z

Part of #1888

github-actions · 2024-04-06T00:05:18Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

src/ServicePulse.Host/vue/src/components/PageHeader.vue

…erQueuesView.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

…View.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue

…ointsView.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

PhilBastian · 2024-07-02T02:41:24Z

src/Frontend/src/assets/main.css

@@ -35,7 +35,7 @@ body {
  display: flex;
  flex-direction: column;
  height: 100vh;
-  min-width: 640px;
+  min-width: 930px;


this is a big increase - this min-width was a (temporary) fix to ensure all the menu items still show when on a smaller resolution viewport. Isn't it just a single extra icon, about 50px including space?

temporary because ideally we'd switch to a hamburger menu below this width, rather than showing a horizontal scrollbar

This is a different setting from the top bar, https://github.com/Particular/ServicePulse/pull/1746/files#diff-19ae39d4ffb6b88034dc79db811f4b812e14e71c20e6f2f9a2fd598f19ec3860L172.
The intention here is to ensure the new screen layout renderers correctly, given it is a large table.

PhilBastian · 2024-07-02T02:56:05Z

src/Frontend/src/stores/ThroughputStore.ts

+
+export const useThroughputStore = defineStore("ThroughputStore", () => {
+  const testResults = ref<ConnectionTestResults | null>(null);
+  const refresh = () => dataRetriever.executeAndResetTimer();


Suggested change

const refresh = () => dataRetriever.executeAndResetTimer();

const refresh = dataRetriever.executeAndResetTimer;

PhilBastian · 2024-07-02T02:58:41Z

src/Frontend/src/stores/ThroughputStore.ts

+
+    return testResults.value.transport as Transport;
+  });
+  const isBrokerTransport = computed(() => {


this would seem safer if the switch defaulted to false rather than true

Given the majority of our transports are "brokers", I thought it is more logical to default to true

PhilBastian · 2024-07-02T03:20:09Z

src/Frontend/src/views/ThroughputReportView.vue

+
+async function generateReport() {
+  const results = await throughputClient.endpoints();
+  const found = results.find((value) => !value.user_indicator);


Suggested change

const found = results.find((value) => !value.user_indicator);

const hasNonUserIndicatorEndpoint = results.find((value) => !value.user_indicator);

PhilBastian · 2024-07-02T03:20:27Z

src/Frontend/src/views/ThroughputReportView.vue

+  const results = await throughputClient.endpoints();
+  const found = results.find((value) => !value.user_indicator);
+
+  if (found) {


Suggested change

if (found) {

if (hasNonUserIndicatorEndpoint ) {

or just use the results.find directly in the if clause

PhilBastian · 2024-07-03T02:31:37Z

src/Frontend/src/views/throughputreport/setup/DiagnosticsView.vue

+      </ConnectionResultView>
+      <ConnectionResultView v-if="useIsMonitoringEnabled()" title="Monitoring" :result="testResults?.monitoring_connection_result!">
+        <template #instructions>
+          <a href="https://docs.particular.net/servicecontrol/monitoring-instances/installation/creating-config-file" target="_blank">Learn how to configure monitor instances</a>


check: are there any links in servicepulse that open in a new tab that (correctly) have the icon next to them indicating that they will open in a new tab? Something similar to this should be used here, at the end of the text https://www.iconfinder.com/icons/192090/external_go_to_hyperlink_link_new_tab_outside_url_icon#size=128 (note that this icon has been used to indicate "external link" rather than "opens in new tab"

PhilBastian · 2024-07-03T02:33:07Z

src/Frontend/src/views/throughputreport/setup/MasksView.vue

+    <div class="col-6">
+      <div>
+        <p>
+          The report that is generated will contain the names of endpoints/queues.<br />


I don't think we should be using <br>

PhilBastian · 2024-07-03T02:38:56Z

src/Frontend/src/views/throughputreport/throughputClient.ts

+          fileName = parse(contentDisposition).parameters["filename"] as string;
+        }
+      } catch {
+        //do nothing


better explanation? Is the parse expected to fail for some headers, and then we are happy to keep the default fileName set above?

PhilBastian · 2024-07-03T02:39:03Z

src/Frontend/src/views/throughputreport/throughputClient.ts

+      try {
+        if (contentDisposition != null) {
+          parse(contentDisposition);
+          fileName = parse(contentDisposition).parameters["filename"] as string;


double parse

PhilBastian · 2024-07-03T02:39:27Z

src/Frontend/src/views/throughputreport/throughputClient.ts

+
+  public async getMasks() {
+    if (isThroughputSupported.value) {
+    const [, data] = await useTypedFetchFromServiceControl<string[]>(`${this.basePath}/settings/masks`);


formatting is wrong

johnsimons · 2024-07-08T00:33:13Z

I haven't addressed the px vs em and breaks <br/>.
Regarding the sizing measurement, I think we need to address that as a complete overall and also have some lint that prevents it.

johnsimons self-assigned this Feb 26, 2024

johnsimons force-pushed the john/report branch 2 times, most recently from 5637f26 to 0ab0828 Compare March 4, 2024 00:56

github-actions bot added the stale label Apr 6, 2024

mikeminutillo reviewed Apr 10, 2024

View reviewed changes

src/ServicePulse.Host/vue/src/components/PageHeader.vue Outdated Show resolved Hide resolved

github-actions bot removed the stale label Apr 11, 2024

johnsimons force-pushed the john/report branch 2 times, most recently from fde9414 to 5c7ca66 Compare April 19, 2024 00:01

johnsimons force-pushed the john/report branch from 4363143 to 83bb9a7 Compare April 24, 2024 04:26

jpalac force-pushed the john/report branch from 83bb9a7 to 8d8f609 Compare May 2, 2024 01:08

johnsimons force-pushed the john/report branch 2 times, most recently from 8b1c4e9 to 30a2a5a Compare May 17, 2024 03:32

johnsimons force-pushed the john/report branch from bf8204d to 8ffece0 Compare May 21, 2024 23:11

johnsimons and others added 16 commits June 18, 2024 08:10

Adding Throughput Report top nav and layout

7137508

Adjust when to hide labels

ed51d80

dfg

3499d07

Adding fake data and more filtering

8c22517

Selecting tab

bb1dc5b

moved component

86a4cfc

Starting setup tab

6a8ebd3

Add navigation away warning

9f08be9

Adding setup data

234a1c8

Adding more to report

381c5f9

Update header menu item

873f463

Updating

06666b2

Enable/disable save

1618d63

Update report and setup tabs

873e04f

Move report button to tab level

41a7f6c

Add a check to see if SC supports throughput

d6c7198

johnsimons and others added 7 commits June 24, 2024 12:00

Update src/Frontend/src/views/throughputreport/endpoints/DetectedBrok…

32c7fef

…erQueuesView.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/endpoints/DetectedList…

74101f4

…View.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/setup/ConnectionSetupV…

1610e87

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/setup/ConnectionSetupV…

4c4b1d9

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/setup/ConnectionSetupV…

002c1dd

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/setup/ConnectionSetupV…

5519423

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Update src/Frontend/src/views/throughputreport/setup/ConnectionSetupV…

8d41842

…iew.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

jpalac approved these changes Jun 24, 2024

View reviewed changes

jpalac reviewed Jun 24, 2024

View reviewed changes

src/Frontend/src/views/throughputreport/endpoints/DetectedEndpointsView.vue Outdated Show resolved Hide resolved

johnsimons and others added 14 commits June 24, 2024 17:09

Update src/Frontend/src/views/throughputreport/endpoints/DetectedEndp…

206d78b

…ointsView.vue Co-authored-by: Jo Palac <jpalac@users.noreply.github.com>

Address transport types enum

5ac006b

update sqlserver transport name

0e8f6bf

cleanup setup + add link to transport settings on docs

ae59cc8

Merge branch 'master' into john/report

92c36e9

Removing duplicate call to useServiceControl

2a7c383

don't show SC setttings for broker transports

fc0a509

Rework has errors logic

380c43a

update required SC version

5fe8832

hide usage config if not supported

ac4c9a5

use storetorefs

9975602

only refresh if throughput is supported

9195fed

fixed link

b5a9bd1

updates to ensure apis are not called when feature is not supported

26433a1

PhilBastian reviewed Jul 3, 2024

View reviewed changes

cquirosj and others added 2 commits July 3, 2024 08:31

Merge branch 'master' into john/report

63c126b

Small fixes based on review

ca4c4c8

johnsimons merged commit b5075bd into master Jul 8, 2024
4 checks passed

johnsimons deleted the john/report branch July 8, 2024 00:33

udidahan changed the title ~~Adding Throughput Report area~~ Adding Usage Report area Jul 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Usage Report area #1746

Adding Usage Report area #1746

johnsimons commented Feb 26, 2024 •

edited by jpalac

Loading

github-actions bot commented Apr 6, 2024

PhilBastian Jul 2, 2024

PhilBastian Jul 2, 2024

johnsimons Jul 7, 2024

PhilBastian Jul 2, 2024

johnsimons Jul 8, 2024

PhilBastian Jul 2, 2024

johnsimons Jul 7, 2024

PhilBastian Jul 2, 2024

johnsimons Jul 8, 2024

PhilBastian Jul 2, 2024

PhilBastian Jul 2, 2024

johnsimons Jul 8, 2024

PhilBastian Jul 3, 2024 •

edited

Loading

PhilBastian Jul 3, 2024

PhilBastian Jul 3, 2024

johnsimons Jul 8, 2024

PhilBastian Jul 3, 2024

johnsimons Jul 8, 2024

PhilBastian Jul 3, 2024

johnsimons Jul 8, 2024

johnsimons commented Jul 8, 2024

	const refresh = () => dataRetriever.executeAndResetTimer();
	const refresh = dataRetriever.executeAndResetTimer;

	const found = results.find((value) => !value.user_indicator);
	const hasNonUserIndicatorEndpoint = results.find((value) => !value.user_indicator);

Adding Usage Report area #1746

Adding Usage Report area #1746

Conversation

johnsimons commented Feb 26, 2024 • edited by jpalac Loading

github-actions bot commented Apr 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhilBastian Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnsimons commented Jul 8, 2024

johnsimons commented Feb 26, 2024 •

edited by jpalac

Loading

PhilBastian Jul 3, 2024 •

edited

Loading