Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display connectedcount/total rather than just connectedcount #1762

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

PhilBastian
Copy link
Contributor

display connectedcount/total rather than just connectedcount and separate the display from the endpoint link

</div>
<span class="endpoint-count" v-if="endpoint.connectedCount || endpoint.disconnectedCount" v-tooltip title="Endpoint instance(s): (connected/total)">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean if both are zero we will display nothing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe in that scenario we wouldn't show the row at all

@johnsimons
Copy link
Member

After spending some time on this, to me, it feels like we have two features that maybe can be merged together.
So we have the "counter" and the "red icon".
image

To the counter, display the current "active" endpoints and the red icon displays whether all instances are "disconnected".

Which makes me wonder if it would be better to remove the icon and have something like:

  1. (10/10) render in green, with tooltip "All instance are online"
  2. (8/10) render in warning color, with tooltip "Some instances are offline"
  3. (0/10) render in red with tooltip "All instance are offline"

Base automatically changed from handle_endpoint_name_overflow to master March 1, 2024 05:06
@PhilBastian
Copy link
Contributor Author

After spending some time on this, to me, it feels like we have two features that maybe can be merged together. So we have the "counter" and the "red icon".

To the counter, display the current "active" endpoints and the red icon displays whether all instances are "disconnected".

Which makes me wonder if it would be better to remove the icon and have something like:

  1. (10/10) render in green, with tooltip "All instance are online"
  2. (8/10) render in warning color, with tooltip "Some instances are offline"
  3. (0/10) render in red with tooltip "All instance are offline"

I would suggest instead that we raise this as a new issue for later attention

@PhilBastian PhilBastian merged commit 0ff57b1 into master Mar 5, 2024
5 checks passed
@PhilBastian PhilBastian deleted the endpoint_instancecount_display branch March 5, 2024 00:01
@cquirosj cquirosj added this to the 1.38.2 milestone Mar 20, 2024
@TravisNickels TravisNickels added the Type: Improvement Type: Improvement label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants