Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Endpoint list default direction for name sorting ascending #1763

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mikeminutillo
Copy link
Member

@mikeminutillo mikeminutillo commented Mar 1, 2024

The default sort order for the endpoint list was descending. This change makes the default sort for the column ascending.

I also created a SortInfo interface and passed that around to bind to instead of having two separate states to pass around.

Fixes #1593

@johnsimons
Copy link
Member

@mikeminutillo I noticed you playing with the sorting, so I thought I mentioned it.
Have you considered passing a comparer as a parameter to it, so that you may make the "property name" typed. Because at the moment is a magic string!

@mikeminutillo mikeminutillo merged commit 09c0735 into master Mar 6, 2024
5 checks passed
@mikeminutillo mikeminutillo deleted the default-endpoint-list-sort branch March 6, 2024 00:50
@cquirosj cquirosj added this to the 1.38.2 milestone Mar 20, 2024
@TravisNickels TravisNickels added the Type: Improvement Type: Improvement label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServicePulse monitoring tab lists enpoints in descending order
5 participants