-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new host to be used for container #1997
Conversation
src/Particular.PlatformSample.ServicePulse/Particular.PlatformSample.ServicePulse.csproj
Show resolved
Hide resolved
Thanks @bording. Just note that the change from port 90 to 9090 was a breaking change for us since our ingress in Azure Container Apps previously exposed port 90. We also had a startup probe hitting port 90. It might be good to include this in the release notes for others (I may have missed this). Edit: I see the new port was noted in Container-README.md, so please disregard my comment, I just didn't read it since I was upgrading from a previous version. |
We have added a note to the release notes and the announcement regarding the change. However, the only thing that really changed was the port inside the container. Externally, you can continue to map that to whatever port you desire. For example using docker:
Would let you keep using 90 as the public-facing port. |
This PR makes the following changes:
app.contants.js
result, removing the need to write those out to disk before serving the website.MONITORING_URL
setting has been added to the container. It accepts a single URI instead of an array of URIs. If this new setting and the oldMONITORING_URLS
are both set, the new setting takes precedence.9090
.