Better handling of endpoints deployed into elastic scale environments #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap tooltip has a hardcoded width and it is quite dificult to configure it based on usage, see https://stackoverflow.com/questions/14596743/how-do-you-change-the-width-and-height-of-twitter-bootstraps-tooltips
Show less for untracked instances in counters
Handle backwards compat
(cherry picked from commit 595bc95)
…Pulse into elastic_scale # Conflicts: # src/Frontend/src/components/heartbeats/HeartbeatConfiguration.vue
This makes it backward-compatible with older versions of ServiceControl
This reverts commit 79cd4eb.
johnsimons
changed the title
johnsimons
changed the title
PhilBastian
approved these changes
Sep 11, 2024
src/Frontend/src/components/heartbeats/EndpointSettingsSupported.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/heartbeats/HeartbeatConfiguration.vue
Outdated
Show resolved
Hide resolved
| <p>{{ endpoint.alive_count }} alive</p> | ||
| </template> | ||
| </template> | ||
| <i v-if="endpoint.track_instances" class="fa fa-server" :class="endpointHealth(endpoint)"></i> |
There was a problem hiding this comment.
we were discussing making these components... Still keen?
There was a problem hiding this comment.
it would definitely be better if we are copy pasting them
…Pulse into elastic_scale # Conflicts: # src/Frontend/src/components/heartbeats/EndpointInstances.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of fixing Update monitoring for elastic scale environments, which allows ServicePulse to better handle endpoint deployments in elastic scale environments.
This PR introduces a few changes to ServicePulse UI/X.
Configuring logical endpoint to handle elastic scale environments
A new configurable option to specify whether logical endpoint instances should be "tracked" or "not tracked".
Track Instancesis the best setting for endpoints where all instances are hosted in physical infrastructure that is not auto-scaled, such as physical or virtual servers.Do Not Track Instancesis the best setting for endpoints hosted in infrastructure with autoscalers. Examples are Kubernetes, Azure Container Apps and AWS Elastic Container Service.This setting is exposed in the Configuration tab of Heartbeats
There is also the option to bulk configure all endpoints as well as set the default for newly discovered endpoints.
Logical endpoints
As part of this change, we've also updated the Heartbeats screens to always display endpoints as logical
In the list above, as you can see, we now display the following:
Track instancesor notEndpoint instances
These are now reached by clicking on the logical endpoints from the above section.
In this screen, you can:
Miscellaneous updates
Documentation
Visit our docs website for documentation regarding this new feature.