Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV exports containing newlines, commas, or quotes are incorrectly formatted #2179

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Dec 3, 2024

Resolves:

CSV export failed to generate a correct CSV as the value can contains \n, , or ".

This change will:

  • Put the value in double quotes if \n, , or " characters are in the "cell" value
  • Escape " characters to "" which seems to be the most common used method to escape double quote characters

@ramonsmits ramonsmits requested a review from dvdstelt December 3, 2024 12:48
@ramonsmits ramonsmits added the Type: Bug Type: Bug label Dec 3, 2024
@ramonsmits ramonsmits added this to the 1.44.2 milestone Dec 3, 2024
@ramonsmits ramonsmits merged commit 843c0b6 into master Dec 3, 2024
4 checks passed
@ramonsmits ramonsmits deleted the csv-export branch December 3, 2024 13:28
@ramonsmits ramonsmits changed the title Fix CSV export with values containing \n, , or " CSV exports containing newlines, commas, or quotes are incorrectly formatted Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants