Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a view for tracking archive process status #428

Merged
merged 16 commits into from
Mar 30, 2017
Merged

Conversation

WojcikMike
Copy link
Contributor

Connects to Particular/PlatformDevelopment#1164

Creating a view for displaying archiving status

Ping @WilliamBZA

@WojcikMike WojcikMike changed the title [WIP] Create a view for tracking archive process status Create a view for tracking archive process status Mar 23, 2017
@WojcikMike
Copy link
Contributor Author

@Particular/servicepulse-maintainers please review as this is ready. To run it you need to use: Particular/ServiceControl#934

@sergioc
Copy link
Contributor

sergioc commented Mar 23, 2017

Nice @WojcikMike. Some feedback:

  • Why isn't there a dismiss action to make it consistent with the behavior of the group retry operation?
  • Once the progress view (the black container) disappears the group doesn't disappear along right away. It takes a few seconds (2-3 secs). I'd expect it to disappear immediately.

@WilliamBZA
Copy link
Member

@sergioc re the disappearing: it depends on the Raven indexes 😞

We'd have to implement some custom delay type code to prevent it from still staying. Getting into the realm of really hacky then though.

@sergioc
Copy link
Contributor

sergioc commented Mar 23, 2017

@WilliamBZA you could set an event to fire when the operation is complete (or better, dismissed) and hide it with CSS display: none; (via a adding a class with Angular, perhaps).

@WilliamBZA
Copy link
Member

@sergioc The removal is fired from signalr when the operation has completed, but the page reload timer that kicks off reloads the data from SC. If the indexes aren't up to date yet SC will report that the group is still there, except it's not currently being archived. So SP then shows the group. When the interval kicks off again, raven might have updated the indexes and would then remove the group.

Dismissing might be a workaround for this as it would hopefully give raven enough time to catch up. Unless the user is quick on the dismiss, and then the problem might still happen.

@sergioc
Copy link
Contributor

sergioc commented Mar 23, 2017

Could you insert a delay before the UI indicates the operation is complete and can be dismissed?

@WilliamBZA
Copy link
Member

@sergioc Yes, but how long should that delay be? The indexes could be stale forever. I think the best option is the Dismiss. That will give a reasonable amount of time between the completion and the refresh to give raven time to catch up.

@sergioc
Copy link
Contributor

sergioc commented Mar 24, 2017

The user can also dismiss right away and group remains there afterwards. I'd do a combination. Maybe a 10sec. delay + dismiss. Better than nothing.

@WilliamBZA
Copy link
Member

Ping some more @Particular/servicecontrol-maintainers to review please. If no comments are made by Wednesday morning, we will merge and release.

@WojcikMike WojcikMike added this to the 1.9.0 milestone Mar 30, 2017
@WojcikMike WojcikMike merged commit 18bf1f5 into master Mar 30, 2017
@WojcikMike WojcikMike deleted the archiving-batches branch March 30, 2017 10:13
@WojcikMike WojcikMike added Type: Feature Type: Feature and removed State: In Progress labels Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants