-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a view for tracking archive process status #428
Conversation
Changing the label from: Message to archive -> Messages left to archive
@Particular/servicepulse-maintainers please review as this is ready. To run it you need to use: Particular/ServiceControl#934 |
Nice @WojcikMike. Some feedback:
|
@sergioc re the disappearing: it depends on the Raven indexes 😞 We'd have to implement some custom delay type code to prevent it from still staying. Getting into the realm of really hacky then though. |
@WilliamBZA you could set an event to fire when the operation is complete (or better, dismissed) and hide it with CSS |
@sergioc The removal is fired from signalr when the operation has completed, but the page reload timer that kicks off reloads the data from SC. If the indexes aren't up to date yet SC will report that the group is still there, except it's not currently being archived. So SP then shows the group. When the interval kicks off again, raven might have updated the indexes and would then remove the group. Dismissing might be a workaround for this as it would hopefully give raven enough time to catch up. Unless the user is quick on the dismiss, and then the problem might still happen. |
Could you insert a delay before the UI indicates the operation is complete and can be dismissed? |
@sergioc Yes, but how long should that delay be? The indexes could be stale forever. I think the best option is the Dismiss. That will give a reasonable amount of time between the completion and the refresh to give raven time to catch up. |
The user can also dismiss right away and group remains there afterwards. I'd do a combination. Maybe a 10sec. delay + dismiss. Better than nothing. |
* Require dismissal of archive operations
Ping some more @Particular/servicecontrol-maintainers to review please. If no comments are made by Wednesday morning, we will merge and release. |
Connects to Particular/PlatformDevelopment#1164
Creating a view for displaying archiving status
Ping @WilliamBZA