refactor: use a NodesSnapshot to avoid lock contention over m_nodes_m…

…utex
PastaPastaPasta · Nov 20, 2024 · 35411e8 · 35411e8
1 parent 9d87d9d
commit 35411e8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/llmq/signing_shares.cpp b/src/llmq/signing_shares.cpp
@@ -1364,9 +1364,10 @@ void CSigSharesManager::Cleanup()
             nodeStatesToDelete.emplace(nodeId);
         }
     }
-    connman.ForEachNode([&nodeStatesToDelete](const CNode* pnode) {
+    const CConnman::NodesSnapshot snap{connman, /* filter = */ CConnman::FullyConnectedOnly};
+    for (const auto& pnode : snap.Nodes()) {
         nodeStatesToDelete.erase(pnode->GetId());
-    });
+    }
 
     // Now delete these node states
     LOCK(cs);