doc: update the content of release notes #29

PastaPastaPasta · 2023-04-10T15:59:10Z

No description provided.

thephez

Heading formatting

doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

doc/release-notes.md

thephez · 2023-04-10T16:50:49Z

doc/release-notes.md

+List of affected messages:
+`dsq`, `dstx`, `mnauth`, `govobj`, `govobjvote`, `qrinfo`, `qsigshare`, `qsigrec`, `isdlock`, `clsig`, and all DKG messages (`qfcommit`, `qcontrib`, `qcomplaint`, `qjustify`, `qpcommit`).
+
+## `qfcommit`


These are all subsections of the BLS stuff right? (qfcommit through mnhftx)

thephez

Adjust BLS section heading levels

doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

thephez · 2023-04-10T17:17:07Z

doc/release-notes.md

 None

 ### Changes in existing RPCs introduced through bitcoin backports:
-None
+
+- The utxoupdatepsbt RPC method has been updated to take a descriptors


Suggested change

- The utxoupdatepsbt RPC method has been updated to take a descriptors

- The `utxoupdatepsbt` RPC method has been updated to take a descriptors

doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

doc/release-notes.md

Co-authored-by: thephez <thephez@users.noreply.github.com>

UdjinM6 · 2023-04-10T18:04:19Z

doc/release-notes.md

+### Downgrade to a version < v19.0.0

-Downgrading to a version older than v18.2.2 is supported.
+Downgrading to a version older than v19.0.0 is supported.

 ### Downgrade to a version < v18.0.1

 Downgrading to a version older than v18.0.1 is not supported due to changes in
 the indexes database folder. If you need to use an older version, you must
 either reindex or re-sync the whole chain.


Suggested change

### Downgrade to a version < v19.0.0

Downgrading to a version older than v18.2.2 is supported.

Downgrading to a version older than v19.0.0 is supported.

### Downgrade to a version < v18.0.1

Downgrading to a version older than v18.0.1 is not supported due to changes in

the indexes database folder. If you need to use an older version, you must

either reindex or re-sync the whole chain.

Downgrade to a version < v19.0.0

Downgrading to a version older than v19.0.0 is not supported due to changes in the evodb database. If you need to use an older version, you must either reindex or re-sync the whole chain.

UdjinM6 · 2023-04-10T18:08:24Z

doc/release-notes.md

+- `cleardiscouraged` clears all the already discouraged peers.
+- The following RPCs were added: `protx register_hpmn`, `protx register_fund_hpmn`, `protx register_prepare_hpmn` and `protx update_service_hpmn`.
+  These HPMN RPCs correspond to the standard masternode RPCs but have the following additional mandatory arguments: `platformNodeID`, `platformP2PPort` and `platformHTTPPort`.
+


upgradewallet, ~~analyzepsbt~~

analyzepsbt was in v18. Where was upgradewallet introduced? I somehow missed that.

dashpay@5f10b3e

UdjinM6 · 2023-04-10T18:08:57Z

doc/release-notes.md

+- Kittywhiskers Van Gogh
+- Konstantin Akimov
+- Munkybooty
+- Nathan Marley
 - Odysseas Gabrielides
+- Oleg Girko
+- pasta
+- strophy
+- thephez
 - UdjinM6
+- Vijay


Suggested change

- Kittywhiskers Van Gogh

- Konstantin Akimov

- Munkybooty

- Nathan Marley

- Odysseas Gabrielides

- Oleg Girko

- pasta

- strophy

- thephez

- UdjinM6

- Vijay

Kittywhiskers Van Gogh (kittywhiskers)

Konstantin Akimov (knst)

Odysseas Gabrielides (ogabrielides)

Oleg Girko (OlegGirko)

PastaPastaPasta

thephez

UdjinM6

Vijay Das Manikpuri (vijaydasmp)

UdjinM6 · 2023-04-10T20:29:01Z

also, the previous doc/release-notes.md file should be archived into doc/release-notes/dash/release-notes-18.2.2.md

PastaPastaPasta · 2023-04-11T03:55:35Z

Resolved your comments in the final PR

fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke) Pull request description: Fixes: ``` fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed. ==1059066== ERROR: libFuzzer: deadly signal #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10) #1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o #2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o #3 0x7f4a3cbbb3bf (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf) #4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a) #5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858) #6 0x7f4a3c7de728 (/lib/x86_64-linux-gnu/libc.so.6+0x25728) #7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35) #8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5 #9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30 #10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9 #11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26 #13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91 #14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9 #15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20 #17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13 #18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13 #19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25 #20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28 #21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2 #22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14 #23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5 #24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o #25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o #26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o #27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92) #28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2) #29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d) ACKs for top commit: practicalswift: cr ACK fa2e614 Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7

f507681 qt: Connect WalletView signal to BitcoinGUI slot directly (Hennadii Stepanov) bd50ff9 qt: Drop redundant OverviewPage::handleOutOfSyncWarningClicks slot (Hennadii Stepanov) 793f195 qt: Drop redundant WalletView::requestedSyncWarningInfo slot (Hennadii Stepanov) Pull request description: This PR: - removes slots whose only job is to emit a signal, since we can use the signal as a slot - connects the`WalletView::outOfSyncWarningClicked` signal to the `BitcoinGUI::showModalOverlay` slot directly, and removes intermediate `WalletFrame` slot and signal - split from #29 This PR does not change behavior. ACKs for top commit: Talkless: tACK f507681, tested on Debian Sid with Qt 5.15.2, no any behavioral changes noticed. promag: Code review ACK f507681. Tree-SHA512: cd636a7e61881b2cbee84d5425d2107a8e39683b8eb32d79dc9ea942db55d5c1979be2f70da1660eaee5de622d10ed5a92f11fc2351de21b84324b10b23d0c96

d54d949 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) Pull request description: Fix dashpay#392. Adding a new item to the `m_wallet_selector` must follow the establishment of a connection between the `WalletView::encryptionStatusChanged` signal and the `BitcoinGUI::updateWalletStatus` slot. This was a regression introduced in bitcoin@20e2e24 (#29). --- An _encrypted_ wallet being auto-loaded at the GUI startup: - on master (eaf09bd) ![Screenshot from 2021-08-03 22-38-49](https://user-images.githubusercontent.com/32963518/128075837-cdbb2047-5327-43ea-b2d5-2dcdef67cdc0.png) - with this PR ![Screenshot from 2021-08-03 22-34-58](https://user-images.githubusercontent.com/32963518/128075572-cb727652-ad44-4b85-bf64-edcd19f9dea1.png) ACKs for top commit: achow101: ACK d54d949 jarolrod: ACK d54d949 Tree-SHA512: 669615ec8e1517c2f4cdf59bd11a7c85be793ba0dda112361cf95e6c2f0636215fed331d26a86dc9b779a49defae1b248232f98dab449584376c111c288e87bb

PastaPastaPasta added 4 commits April 10, 2023 10:41

doc: update the content of release notes

c986d01

doc: minor changes

a031bb9

doc: add list of contributors

ff801cb

doc: add high level overview of HPMNs

2a4ec1b

thephez suggested changes Apr 10, 2023

View reviewed changes

doc: unify header format

7d42f6d

Co-authored-by: thephez <thephez@users.noreply.github.com>

thephez reviewed Apr 10, 2023

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

docs: more header formatting

c229548

Co-authored-by: thephez <thephez@users.noreply.github.com>

thephez reviewed Apr 10, 2023

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

thephez reviewed Apr 10, 2023

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

doc/release-notes.md Outdated Show resolved Hide resolved

doc/release-notes.md Outdated Show resolved Hide resolved

doc/release-notes.md Outdated Show resolved Hide resolved

PastaPastaPasta and others added 6 commits April 10, 2023 11:57

doc: adjust headings

837dc1f

Co-authored-by: thephez <thephez@users.noreply.github.com>

doc: adjust wording

384c852

Co-authored-by: thephez <thephez@users.noreply.github.com>

doc: adjust formatting

a319cdf

doc: adjust formatting

39e02d3

doc: simplify

3249f24

move updated rpc to updated section

d347ee3

thephez reviewed Apr 10, 2023

View reviewed changes

PastaPastaPasta added 3 commits April 10, 2023 12:17

doc: add coinjoin update

d7d4181

doc: add ``

9d973fe

doc: adjust command line options section

52de909

thephez reviewed Apr 10, 2023

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

doc: minor changes

07f06b1

Co-authored-by: thephez <thephez@users.noreply.github.com>

thephez reviewed Apr 10, 2023

View reviewed changes

doc/release-notes.md Outdated Show resolved Hide resolved

doc: one more colon

f5ee583

Co-authored-by: thephez <thephez@users.noreply.github.com>

PastaPastaPasta merged commit f7e6e4a into v19.x-bp-final Apr 10, 2023

UdjinM6 reviewed Apr 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: update the content of release notes #29

doc: update the content of release notes #29

PastaPastaPasta commented Apr 10, 2023

thephez left a comment

thephez Apr 10, 2023 •

edited

Loading

PastaPastaPasta Apr 10, 2023

thephez left a comment

thephez Apr 10, 2023

UdjinM6 Apr 10, 2023

UdjinM6 Apr 10, 2023 •

edited

Loading

thephez Apr 10, 2023

UdjinM6 Apr 10, 2023

UdjinM6 Apr 10, 2023

UdjinM6 commented Apr 10, 2023 •

edited

Loading

PastaPastaPasta commented Apr 11, 2023

	- The utxoupdatepsbt RPC method has been updated to take a descriptors
	- The `utxoupdatepsbt` RPC method has been updated to take a descriptors

doc: update the content of release notes #29

doc: update the content of release notes #29

Conversation

PastaPastaPasta commented Apr 10, 2023

thephez left a comment

Choose a reason for hiding this comment

thephez Apr 10, 2023 • edited Loading

Choose a reason for hiding this comment

PastaPastaPasta Apr 10, 2023

Choose a reason for hiding this comment

thephez left a comment

Choose a reason for hiding this comment

thephez Apr 10, 2023

Choose a reason for hiding this comment

UdjinM6 Apr 10, 2023

Choose a reason for hiding this comment

UdjinM6 Apr 10, 2023 • edited Loading

Choose a reason for hiding this comment

thephez Apr 10, 2023

Choose a reason for hiding this comment

UdjinM6 Apr 10, 2023

Choose a reason for hiding this comment

UdjinM6 Apr 10, 2023

Choose a reason for hiding this comment

UdjinM6 commented Apr 10, 2023 • edited Loading

PastaPastaPasta commented Apr 11, 2023

thephez Apr 10, 2023 •

edited

Loading

UdjinM6 Apr 10, 2023 •

edited

Loading

UdjinM6 commented Apr 10, 2023 •

edited

Loading