Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Factory and a Configuration Class #1

Merged
merged 4 commits into from
Mar 11, 2012
Merged

Added a Factory and a Configuration Class #1

merged 4 commits into from
Mar 11, 2012

Conversation

Belphemur
Copy link

Hi,

I added a factory and the configuration class that use it.

The Factory do all the check needed on the configuration to be sure it's valid before trying to create the DatabaseHandler. All the check are done in the Configuration class.

I'm using some enum to define the DatabaseType and the Parameter that will be set in the Configuration.

@PatPeter
Copy link
Owner

I was between two versions of the library, the changelog of which you can see on the project page. I no longer know if merging your changes will work.

PatPeter added a commit that referenced this pull request Mar 11, 2012
Belphemur added a database factory and a database configuration file to set easily.
@PatPeter PatPeter merged commit d6a0c56 into PatPeter:master Mar 11, 2012
@PatPeter
Copy link
Owner

I was afraid renaming Database.java would interfere with the merge, but it worked! Thanks for your contribution.

@Belphemur
Copy link
Author

Well since you should have receive a email when I pulled, I thought that sending you a message was useless :)

@PatPeter
Copy link
Owner

Yeah, usually I check my e-mail everyday but for whatever reason hadn't checked it for a week. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants