Update non damaging ailments (Shock, Chill, etc) to PoE 2 Values

[QuickStick123]

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

In PoB 2 the ailments aren't calculated correctly.
See https://www.poe2wiki.net/wiki/Shock and https://www.poe2wiki.net/wiki/Chill
The new values are 20% increased damage for shock and 50% for chill. There is new logic on application chance as chance increases and isn't guaranteed on crit.

There is also a bug where it seems Lightning damage isn't applying shock likely introduced in one of ailment PRs.

Describe the solution you'd like

I would like the chance calculation to presented similarly to how effect is currently presented and the values updated to poe 2 values.

Describe alternatives you've considered

No response

Additional context

No response

[LocalIdentity]

Base stats of chill and shock have been updated here PathOfBuildingCommunity/PathOfBuilding-PoE2-v2#15

[VisNyliss]

Shock Effect is now effectively capped at 20% per stack in POB2 v0.2.0

In-game, I can apply 2 stacks of Shock at 37%

In POB2, I set the Config so that the Enemy is Shocked, Effect of Shock: 37 and Stacks: 2 as shown here

In Calcs > Non-Damaging Ailments it is showing Current Shock : 40% and calculating 2 Shocks at 20%

Adjusting the Effect of Shock value in Configs changes nothing when set to any value over 20, but lowering the value will scale DPS down as expected

[QuickStick123]

Is that caused by overcharge / shock magnitude?

[VisNyliss]

I don't use Overcharge on my Spark, but there's quite a bit of Magnitude of Shock on the tree apart from Harmonic Generator

Alternating Current and the 3 Small Passives leading to it total 50% increased Magnitude

Power Conduction gives another 25%

And then I get another 11% from a jewel

...but now I want to see if I can swap a support for Overcharge and see what kind of shock I'm doing then

[VisNyliss]

Well, I swapped out Arcane Tempo for Overcharge and now I have 2x 52% Shocks