Fix Cursecarver variants #1008
Merged
Fix Cursecarver variants #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When I first added the new unique, I didn't realize it could have multiple versions of the +4 mod. The mod wasn't getting parsed as it's a skill name, not a Skill Type, so I added a separate line for it. It seems to function properly, it gives +4 to the proper curse no matter if it's the active skill or not, and taking the tree node Endless Blizzard correctly still applies +4 to cold skills. So Hypothermia was +5 total.
However, if someone could implement this into the line just 2 below, and have it look for Skill Name as well as skill type, maybe that would be better? Didn't try myself, looked a little complicated and not sure if we'd want to complicate it more or have a separate line.
After screenshot: