Add proper support for pasting items with lesser and greater runes #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x missing floating point handling on greedy search solutions
… breakpoint analysis
Member
|
I don't have runes to test with in the latest patch, does this work properly when importing via the API still? |
QuickStick123
changed the title
…fortunately removes the 1 rune type check as I am not confident in it always producing a minimal number of runes. Cause if it doesn't then problems could arise of then not having enough rune slots to find the other runes on the item.
LocalIdentity
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992
Description of the problem being solved:
As there are now multiple runes of different types it becomes harder to guess the runes used on the item.
This PR aims to solve this issue by generating a minimal combination of runes that meets the stats present on the item. This means it will always generate a set of runes that add to the total if it can, otherwise it won't. This does however mean some runes combinations won't be accurately reflexed as they are ingame e.g.
Will get imported as
But I think this is a minor issue as it should be right in most cases of people using the runes. But will sometimes get it wrong mostly with runes values that linear combinations of others e.g. if some uses 2 lesser +20 life runes it will always be importer as a single greater +40 life rune.
This approach uses a greedy base, and then performs search on top of it this should avoid efficiencies potentially lost due to inefficiencies, avoid searching duplicate combinations and is constrained as better searches are found. This was made using ChatGPT as a base them modifying it to suit the runes as well as a few optimisations and changes.
Before screenshot:
After screenshot: