Skip to content

Conversation

@majochem
Copy link
Contributor

Description of the problem being solved:

  • Mods that grant ailment chance for critical strikes only, were previously parsed, but not actually accounted for in chance calculations for poison and bleed. Now they are accounted for.
  • Example: "10% chance to inflict Bleeding on Critical Hit with Attacks" from "Perfectly Placed Knife" passive tree cluster
  • Also keeps the "OVERRIDE" check for ailment (bleed/poison) chance that is introduced in Add support for Splinter of Loratta (Unique Spear) #1054

Steps taken to verify a working solution:

  • Only counted on Crit
  • Correctly displayed in breakdown

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/yj1he083

After screenshot:

Bleed
image

Poison
image

@majochem majochem marked this pull request as ready for review April 23, 2025 12:55
@majochem majochem marked this pull request as draft April 24, 2025 09:42
@majochem majochem marked this pull request as ready for review April 24, 2025 10:04
@LocalIdentity LocalIdentity merged commit 5eaf2b8 into PathOfBuildingCommunity:dev May 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants