Skip to content

Fix Beidat's Hand Energy Shield per Max Life mod not working #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
May 7, 2025
Merged

Fix Beidat's Hand Energy Shield per Max Life mod not working #1113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d0885
FIX: Beidat's Hand order of calcs issue
Paliak May 7, 2025
6a0f07e
FIX: skip breakdown on first call to doActorLifeManaSpirit
Paliak May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Modules/CalcDefence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ end

-- Calculate life/mana/spirit pools
---@param actor table
function calcs.doActorLifeManaSpirit(actor)
function calcs.doActorLifeManaSpirit(actor, skipBreakdown)
local modDB = actor.modDB
local output = actor.output
local breakdown = actor.breakdown
local breakdown = (not skipBreakdown) and actor.breakdown
local condList = modDB.conditions

local lowLifePerc = modDB:Sum("BASE", nil, "LowLifePercentage")
Expand Down Expand Up @@ -1065,6 +1065,8 @@ function calcs.defence(env, actor)
end
-- Primary defences: Energy shield, evasion and armour
do
-- Pre-calculate Life/Mana/Spirit for mods such as Beidat's hand
calcs.doActorLifeManaSpirit(actor, true)
local ward = 0
local energyShield = 0
local armour = 0
Expand Down