Fix crash when deleting newly created config set #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
added
crash
LocalIdentity
approved these changes
May 12, 2025
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…nity#1120) * FIX: save id into selValue instead of table * FIX: same issue as e711588 but for items and gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1115 (comment)
Description of the problem being solved:
Creating a new config/skill/item set would save the entire table into self.selValue which is then later used as an index. Since the configSets table is indexed by ids instead it returns null and causes a crash.
This pr simply makes the save button function save the id instead of the full table. This also makes the newly created config set highlight nicely.
Link to a build that showcases this PR:
See reproduction steps in issue. See #1115 for screenshots.