Fix Gem tooltips crashing on Linux #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, I'm Nighty, executive pedant, human-powered linter, and officially the unofficial imaginary mascot of PoB. |
LocalIdentity
approved these changes
Aug 20, 2025
LocalIdentity
changed the title
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
… coverage (PathOfBuildingCommunity#1169) * Fix path case sensitivity of 'specific skill stat description' in StatDescriber (for Linux) * Fix file handler leak in StatDescriber * Normalize scope name handling for case sensitivity on Linux * Add tests for the StatDescriber getScope * Fix indents --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1168
Description of the problem being solved:
When running Path of Building on Linux/WSL, the application failed to load skill-specific stat descriptions due to case-sensitivity issues. Generated stat description files sometimes reference parent scopes with lowercase "specific_skill_stat_descriptions/" prefixes, but the actual directory is "Specific_Skill_Stat_Descriptions" (title case). This caused runtime errors like "cannot open Data/StatDescriptions/specific_skill_stat_descriptions/herald_of_thunder_statset_1.lua".
Additionally, the StatDescriber was using incorrect file closing syntax that could leak file handles.
Steps taken to verify a working solution:
getScopefunction, and all tests pass (docker-compose upshows 75 successes / 0 failures)Link to a build that showcases this PR:
(Any build using Herald of Thunder, Alchemist's Boon, or other skills with specific stat descriptions will reproduce this issue on Linux/WSL systems)
Before screenshot:
After screenshot:
Commits included in this PR:
Files changed: