Add support for 0.3 Giant's Blood change #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversions (like conversion to ES from GhostWrithe) occur
… mod on Giant's Blood keystone
Nightblade
added
bug: calculation
LocalIdentity
approved these changes
Aug 29, 2025
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
* changes to fix issue where CI wasn't correctly overriding life before conversions (like conversion to ES from GhostWrithe) occur * added support for new "Halves the amount of Life granted by Strength" mod on Giant's Blood keystone * removing prior CI commit accidentally included in this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue from Third Edict spreadsheet: https://docs.google.com/spreadsheets/d/1QN7TJMQT_rxxyYN8rrgbYS2Zta1kFeNGnwhLUIDPLgw/edit?usp=sharing.
Description of the problem being solved:
Adds support for new Giant's Blood mod "halves the amount of life granted by strength"
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/QN7O24ZKg5gm
(This is the build without Giant's blood allocated. Note that the tree.lua needs to be updated to include the new mod prior to testing. I tested by hand modifying the 0_2 tree.lua to add the new mod.
Before screenshot (without Giant's Blood allocated):
After screenshot (with Giant's Blood allocated):