Add support for new "+X% of Armour also applies to Y Damage" mods #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New passive tree nodes were introduced and wording on some of the existing mods was changed. to now include a "+" or "also"
LocalIdentity
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New passive tree nodes were introduced and wording on some of the existing mods was changed. to now include a "+" or "also", or no longer include "taken from hits"
Note:
I chose to have two separate lines for the versions with and without "taken from hits" because afaik there is no safe to include patterns for an optional string that contains multiple spaces with the way the patterns are currently processed. Something like
t?a?k?e?n? ?f?r?o?m? ?h?i?t?s?has too high of a chance for false positives imo.Screenshots: