Update "item <defence>" related modifiers #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGG added the word "item" to many modifiers that are based on the defence stats provided by equipped items. Some of those were already updated, but several were still missing. e.g.: "Spectral Ward" and "Subterfuge Mask" notables. Changes: - Added `(i?t?e?m? ?)` to mods where relevant - Updated "armour *or* evasion" to work with "armour *and* evasion" - Added additional conditions "UsingFocus" and "UsingShield" respectively for mods that were based on "<defence>OnWeapon2" - Change "on items" to "on armour items" in one case
LocalIdentity
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GGG added the word "item" to many modifiers that are based on the defence stats provided by equipped items. Some of those were already updated, but several were still missing.
Changes:
(i?t?e?m? ?)to mods where relevantAffected Nodes:
Still unsupported: "Revenge" (because it provides Thorns Damage, which I don't think is fully supported yet)
Test Build:
Test Build
After screenshot: