Skip to content

Add support for Gigantic Following and fix Hulking Minions #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

Add support for Gigantic Following and fix Hulking Minions #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
309d7b7
Minions are Gigantic
Blitz54 Sep 2, 2025
fecaab9
Fix Hulking Minions
Blitz54 Sep 3, 2025
96f7b3b
Implement in CalcPerform to not duplicate effect
Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Data/ModCache.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5770,7 +5770,7 @@ c["Your Hits cannot be Evaded by Pinned Enemies"]={nil,"Your Hits cannot be Evad
c["Your Life Flask also applies to your Minions"]={nil,"Your Life Flask also applies to your Minions "}
c["Your Life Flask also applies to your Minions Minions cannot Die while affected by a Life Flask"]={nil,"Your Life Flask also applies to your Minions Minions cannot Die while affected by a Life Flask "}
c["Your Life cannot change while you have Energy Shield"]={{[1]={flags=0,keywordFlags=0,name="EternalLife",type="FLAG",value=true}},nil}
c["Your Minions are Gigantic"]={nil,"Your Minions are Gigantic "}
c["Your Minions are Gigantic"]={{[1]={flags=0,keywordFlags=0,name="MinionModifier",type="LIST",value={mod={flags=0,keywordFlags=0,name="Gigantic",type="FLAG",value=true}}}},nil}
c["Your Offerings affect you instead of your Minions"]={nil,"Your Offerings affect you instead of your Minions "}
c["Your Offerings affect you instead of your Minions Offerings created by Culling Enemies have 1% increased Effect per Power of Culled Enemy"]={nil,"Your Offerings affect you instead of your Minions Offerings created by Culling Enemies have 1% increased Effect per Power of Culled Enemy "}
c["Your Offerings can target Enemies in Culling range"]={nil,"Your Offerings can target Enemies in Culling range "}
Expand Down
3 changes: 3 additions & 0 deletions src/Data/SkillStatMap.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2238,6 +2238,9 @@ return {
["minion_block_%"] = {
mod("MinionModifier", "LIST", { mod = mod("BlockChance", "BASE", nil) }),
},
["minions_are_gigantic"] = {
mod("MinionModifier", "LIST", { mod = flag("Gigantic") }),
},
["base_number_of_zombies_allowed"] = {
mod("ActiveZombieLimit", "BASE", nil),
},
Expand Down
8 changes: 0 additions & 8 deletions src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3103,14 +3103,6 @@ skills["SupportHulkingMinionsPlayer"] = {
label = "Hulking Minions",
incrementalEffectiveness = 0.054999999701977,
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_titanblood_minion_damage_+%_final"] = {
mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }),
},
["support_titanblood_minion_life_+%_final"] = {
mod("MinionModifier", "LIST", { mod = mod("Life", "MORE", nil) }),
},
},
baseFlags = {
},
stats = {
Expand Down
8 changes: 0 additions & 8 deletions src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,14 +675,6 @@ statMap = {

#skill SupportHulkingMinionsPlayer
#set SupportHulkingMinionsPlayer
statMap = {
["support_titanblood_minion_damage_+%_final"] = {
mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }),
},
["support_titanblood_minion_life_+%_final"] = {
mod("MinionModifier", "LIST", { mod = mod("Life", "MORE", nil) }),
},
},
#mods
#skillEnd

Expand Down
4 changes: 4 additions & 0 deletions src/Modules/CalcPerform.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,10 @@ local function doActorAttribsConditions(env, actor)
modDB:NewMod("Life", "INC", m_floor(40 * shrineEffectMod), "Massive Shrine")
modDB:NewMod("AreaOfEffect", "INC", m_floor(40 * shrineEffectMod), "Massive Shrine")
end
if modDB:Flag(nil, "Gigantic") then
modDB:NewMod("Life", "MORE", 20, "Gigantic")
modDB:NewMod("Damage", "MORE", 20, "Gigantic")
end
end
if env.mode_effective then
if env.player.mainSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "FireExposureChance") > 0 or modDB:Sum("BASE", nil, "FireExposureChance") > 0 then
Expand Down
3 changes: 3 additions & 0 deletions src/Modules/ModParser.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4171,6 +4171,9 @@ local specialModList = {
["companions gain your dexterity"] = { flag("DexterityAddedToCompanions") },
["companions gain your strength"] = { flag("StrengthAddedToCompanions") },
["half of your strength is added to your minions"] = { flag("HalfStrengthAddedToMinions") },
["your minions are gigantic"] = {
mod("MinionModifier", "LIST", { mod = flag("Gigantic") }),
},
["minions created recently have (%d+)%% increased attack and cast speed"] = function(num) return { mod("MinionModifier", "LIST", { mod = mod("Speed", "INC", num) }, { type = "Condition", var = "MinionsCreatedRecently" }) } end,
["minions created recently have (%d+)%% increased movement speed"] = function(num) return { mod("MinionModifier", "LIST", { mod = mod("MovementSpeed", "INC", num) }, { type = "Condition", var = "MinionsCreatedRecently" }) } end,
["minions poison enemies on hit"] = { mod("MinionModifier", "LIST", { mod = mod("PoisonChance", "BASE", 100) }) },
Expand Down