Add ability to sort tree and gear slots by Spirit and Item Rarity #1325
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Sep 9, 2025
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Description of the problem being solved:
The current Stat Weight Multiplier does not have Spirit or Increased Item Rarity as a stat. This makes them unavailable for use in the trade query's stat weighting system.
This PR introduces the necessary logic to integrate both Spirit and Rarity into the trading calculation pipeline.
Steps taken to verify a working solution:
Used the "Trader" to create a weighted search using both Spirit and Rarity to confirm the filter generation is working as expected.
Spellchecked :
Link to a build that showcases this PR:
Before screenshot:
(A screenshot of the Calcs tab or Trader showing Spirit/Rarity as missing)
After screenshot:
(A screenshot showing Spirit and Rarity available for weighting in the Trader.)
