Skip to content

Fix Channel Time on Incinerate #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Sep 16, 2025
Merged

Fix Channel Time on Incinerate #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2641,7 +2641,10 @@ function calcs.offence(env, actor, activeSkill)
end
if skillData.channelTimeMultiplier then
local minTime = skillData.minChannelTime or 0
local channelTime = skillData.channelTimeOverride or output.Speed
local channelTime = output.Speed
if skillData.channelTimeOverride then
channelTime = 1 / skillData.channelTimeOverride
end
output.ChannelTime = m_max(skillData.channelTimeMultiplier / channelTime, minTime)
output.ChannelSpeed = output.Speed or output.Time
end
Expand Down Expand Up @@ -2850,7 +2853,10 @@ function calcs.offence(env, actor, activeSkill)
end
if skillData.channelTimeMultiplier then
local minTime = skillData.minChannelTime or 0
local channelTime = skillData.channelTimeOverride or output.Speed
local channelTime = output.Speed
if skillData.channelTimeOverride then
channelTime = 1 / skillData.channelTimeOverride
end
output.ChannelTime = m_max(skillData.channelTimeMultiplier / channelTime, minTime)
output.ChannelSpeed = output.Speed or output.Time
end
Expand Down