Onslaught movement speed fix #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not sure what the "similar stats" are from Skill Speed, but Warcry speed is just called "WarcrySpeed" as a mod in the code if you want to just add that in this PR |
Contributor
Author
Added, but not sure |
Wires77
reviewed
Jan 20, 2025
src/Modules/CalcPerform.lua
Outdated
| modDB:NewMod("Speed", "INC", effect, "Onslaught", ModFlag.Cast) | ||
| modDB:NewMod("Speed", "INC", 2 * effect, "Onslaught", ModFlag.Attack) | ||
| modDB:NewMod("Speed", "INC", 2 * effect, "Onslaught", ModFlag.Cast) | ||
| modDB:NewMod("Speed", "INC", 2 * effect, "Onslaught", ModFlag.Warcry) |
Member
There was a problem hiding this comment.
It's not a ModFlag, literally a mod name:
Suggested change
| modDB:NewMod("Speed", "INC", 2 * effect, "Onslaught", ModFlag.Warcry) | |
| modDB:NewMod("WarcrySpeed", "INC", 2 * effect, "Onslaught") |
Contributor
Author
|
Fixed |
Wires77
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232 .
Description of the problem being solved:
Onslaught is 10% ms in PoE2 instead of 20% ms (PoE1).
NOTE: Skill speed implementation seems to be not done yet, will need updates in later PRs
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: