Fix Herald interaction with Coming Calamity #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where `Herald of Ash` and `Herald of Ice` were not considered buffs when calculating damage increases with the passive point `Coming Calamity`.
3 tasks
Contributor
|
The gem lua files need to be exported from the game files with changes to the same name .txt file |
added 2 commits
January 21, 2025 05:05
LocalIdentity
approved these changes
Jan 20, 2025
LocalIdentity
changed the title
Contributor
Author
|
@LocalIdentity thank you for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where
Herald of AshandHerald of Icewere not considered buffs when calculating damage increases with the passive pointComing Calamity.Fixes #253 .
Description of the problem being solved:
Herald of Ice and Herald of Ash were not considered buffs, thus Coming Calamity was not applied to cold/fire damage respectively (i.e. 50% increased cold/fire damage).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/k672067b
Before screenshot:
After screenshot:
P.S. 1: There is also a weird bug where sometimes in order for Heralds to be considered buffs, I have to remove it from the skill gems and add it again, but I don't understand why.
P.S. 2: I am not sure that this fix is the right approach, I did my best by understanding other fixes in the codebase, hope this helps. Thank you for this amazing tool!