Add support for Monk's Into the Breach and Lucid Dreaming Ascendancies #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nostrademous
commented
Jan 20, 2025
Nostrademous
commented
LocalIdentity
approved these changes
Jan 20, 2025
LocalIdentity
requested changes
Jan 20, 2025
Comment on lines
199
to
203
| modList:NewMod("Multiplier:BreachFlamesCount", "BASE", m_min(val, 10), "Config") | ||
| modList:NewMod("Multiplier:FlameEffect", "BASE", 1, "Config") | ||
| modList:NewMod("InstantLifeLeech", "BASE", 7, "Config", { type = "Multiplier", var = "BreachFlamesCount" }, { type = "Multiplier", var = "FlameEffect" }, { type = "GlobalEffect", effectType = "Buff" }) | ||
| modList:NewMod("InstantManaLeech", "BASE", 7, "Config", { type = "Multiplier", var = "BreachFlamesCount" }, { type = "Multiplier", var = "FlameEffect" }, { type = "GlobalEffect", effectType = "Buff" }) | ||
| modList:NewMod("DamageGainAsChaos", "BASE", 7, "Config", { type = "Multiplier", var = "BreachFlamesCount" }, { type = "Multiplier", var = "FlameEffect" }, { type = "GlobalEffect", effectType = "Buff" }) |
Contributor
There was a problem hiding this comment.
This config should just be setting the multiplier for flame stacks and should be passed to a stat map on the Into the Breach gem
LocalIdentity
approved these changes
Jan 20, 2025
LocalIdentity
merged commit 9eb6b39
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
LocalIdentity
changed the title
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.