Fix tooltips for passive node mods of type FLAG scaled by Hulking Form #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peechey
changed the title
Peechey
changed the title
Peechey
added
user-interface
LocalIdentity
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583
Description of the problem being solved:
Certain nodes on the tree are only there to enable a condition or flag a config etc and therefore do not have a value internally on the mod. The increased effect from Hulking Form and others isn't expecting a non-number value for scaling so it sets to 0. This PR grabs the number from the line/sd and sends it through the scaler instead of the boolean value. Strictly UI/tooltip issue, flags/conditions/internal calcs all good.
Before screenshot:
After screenshot: