Skip to content

Conversation

@Jonathan-Dang
Copy link
Contributor

Description of the problem being solved:

Implements damage calculation from critical hits regard the Invoker Monk Ascendancy "Sunder my Enemies..."

Steps taken to verify a working solution:

  • Create a weapon with all three elemental damage types present, as well as set critical strike chance to 100% or higher.
  • Set attack gem to any gem that can deal elemental damage
  • Set Enemy elemental resists greater than 0; 1000 in test [effective 80%]
  • See Average Damage breakdown to see if crit damage is unaffected by elemental resists

Link to a build that showcases this PR:

https://pobb.in/yLzlR-6lbh0c

Before screenshot:

Node in Tree

image

General Calc View [Storm Wave]

image

After screenshot:

Node in Tree

image

General Calc View [Storm Wave]

image

Jonathan-Dang and others added 4 commits January 26, 2025 15:53
NOTE: In breakdown, it will not show as crit cfg add-on isn't implemented yet.
Only visible change in Average and Skill DPS.
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the mod applying on non-crits and the parsing for the mod was missing aa % to escape the hyphen in the middle of the string

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 27, 2025
@LocalIdentity LocalIdentity changed the title Adds "Sunder my Enemies..." Invoker Monk Ascendancy Support Add support for Monk's "Sunder my Enemies..." Invoker Ascendancy Jan 27, 2025
@LocalIdentity LocalIdentity merged commit b63d65c into PathOfBuildingCommunity:dev Jan 27, 2025
2 checks passed
@Jonathan-Dang Jonathan-Dang deleted the Sunder-My-Enemies-Invoker branch January 28, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants