Fix item range crash on ventor's gamble #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
added
bug
QuickStick123
changed the title
Wires77
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ventor's stats weren't showing and would disappear resulting it the list getting corrupted and crashing. This was introduced in the proper scalability PR and resulted in signs not being presented on 0 values causing mod parser to fail resulting in them being hidden, this changes it such that the + sign is used for 0 values like it did previously.
This crashing behaviour could reappear if a slider causes any modLine to no longer be parsed.
Before screenshot:
After screenshot: