Fix gems not showing the correct stats on some parts #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can no longer use the unresolved values for skills with multiple levels as some skills grab the base value from the first set and add it to the second/third and this doesn't work correctly with the previous method This also removes a bunch of duplicate stats that appeared on some skills I made it so that skills with only 1 level keep the previous method of only using the statInterpolation formula as otherwise it would break minion skills that work this way There is still an issue where running the export script multiple times without restarting the exporter will duplicate the constant stat entries but I was running out of time to fix it The only actual issue with a gem now is the ShieldCharge gem which has too many statInterpolation entries. It doesn't cause any issues in the program but would be nice to fix as it may cause an issue in the future on another gem
Wires77
force-pushed
the
fix_stat-sets
branch
from
40c8c67 to
361f7c7
Compare
* Updated skills.lua to not duplicate stats * AdditionalStats are being set as resolved values now
Wires77
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can no longer use the unresolved values for skills with multiple levels as some skills grab the base value from the first set and add it to the second/third and this doesn't work correctly with the previous method
This also removes a bunch of duplicate stats that appeared on some skills
I made it so that skills with only 1 level keep the previous method of only using the statInterpolation formula as otherwise it would break minion skills that work this way
There is still an issue where running the export script multiple times without restarting the exporter will duplicate the constant stat entries but I was running out of time to fix it
The only actual issue with a gem now is the ShieldCharge gem which has too many statInterpolation entries. It doesn't cause any issues in the program but would be nice to fix as it may cause an issue in the future on another gem
Before:
After:
Fixes #412