Skip to content

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Feb 3, 2025

Fixes #498 .

Description of the problem being solved:

  • Add support for Heavy Frost passive notable: "hits ignore non%-negative elemental resistances of frozen enemies"
  • Add support for Choir of the Storm mod: "critical hits ignore enemy monster lightning resistance"
  • Include modifiers that ignore resistances in effective DPS breakdown (non-crit only)
  • Rename "CritIgnoreNonNegativeEleRes" to "IgnoreNonNegativeEleRes" for better compatibility
  • Note: this does not fully fix Add support for non-negative elemental resistances mods #498 as part of the problem is critical strike calculations not being shown properly in Calcs tab, but that is not limited to mods that ignore ele res

Steps taken to verify a working solution:

  • Check effective DPS is correct under conditions
  • Check that effective DPS is correct when conditions are not met
  • Check mod texts are properly colored "blue"

Link to a build that showcases this PR:

TestBuild

Before screenshot:

None

After screenshot:

498_HeavyFrost_1

498_HeavyFrost_2

498_ChoirOfTheStormWorking

@majochem majochem marked this pull request as ready for review February 3, 2025 11:12
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Feb 4, 2025
@LocalIdentity LocalIdentity merged commit e385a7f into PathOfBuildingCommunity:dev Feb 4, 2025
2 checks passed
@LocalIdentity LocalIdentity changed the title Add/improve support for "ignore (non-negative) elemental resistances" mods [Heavy Frost, Choir of The Storm] Add support for "ignore (non-negative) elemental resistances" mods Feb 4, 2025
@majochem majochem deleted the 498-HeavyFrost branch February 13, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for non-negative elemental resistances mods

2 participants