Skip to content

Conversation

@IllusionElements
Copy link
Contributor

Description of the problem being solved:

Updated the exposure values in the modparser to the poe2 value of 20%.
Also adjusted the ailment code to allow for the shock override to work, because for shock it kept taking the minimum shock value, so if you entered in a larger value for the shock it would just take the default 20% but if you went lower it would take the lower value.

Steps taken to verify a working solution:

  • ran the tests and ensured they all passed
  • made sure pob-poe2 still worked after the changes and rebuilt the cache files
  • tested both the exposure and shock value in the app, with the changes to ensure they were accurate

@LocalIdentity LocalIdentity added the technical Hidden from release notes label Feb 10, 2025
@LocalIdentity LocalIdentity changed the title Update Exposure Values and Enabling Shock Override Update Exposure Values in ModParser Feb 10, 2025
@LocalIdentity LocalIdentity merged commit 1b31293 into PathOfBuildingCommunity:dev Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants