Skip to content

Conversation

@nessgor
Copy link
Contributor

@nessgor nessgor commented Feb 6, 2025

Fixes #644 .

Description of the problem being solved:

Reservation should be rounded up

Steps taken to verify a working solution:

  • Tested on POB2
  • Automatic tests successful
image

Link to a build that showcases this PR:

eNrtXVtX47iyfp78Ci_WmvPSafD90oees0JCgOHaBOjueWGZWCEGx0770hD22v_9VEm-yEnsOGH3bM4-9APtSFUlqVT6VCVL8u7_PE884ScJIzfwP29J2-KWQPxh4Lj-_eet66v-R3Prf_5o7V7Y8fh8tJe4HubIf7R-26U_BI_8JN7nLVPaEoaeHUVn9oR83joN_MctwY6GxHe6RfKR_zN4JOGWENvhPYlvsmLFW2Qf26E9jEl4giI7SRycBg4wxWFCtoSJ7fqDYPhI4oMwSKZQ1S3hp0ueGM3R6cX55dUWVOu33QvPnpFwENuxEMGfz1sdaJ59T3r2BP4Cl-0lwCLrurEtSqpoWoqoa1s7tcx7SRjFm0kYTAlxciZ1WzZ1qYr2IiT7oxEZxu5P0g3duDu2_WFRoiRWMS4hNretOurTxIvdqedid2QN2jYrW3G4KL9S_FUQ217vYlDUW1IVMC3TEk1TMox6viDO-Sqb-9WNx3se6HWDUo7ufTcmPKMmQsM1WdOB0dKUukIXmaFUU9q2VFVRVbCIOuaLwI0C_xWK2aDS3cTzYMTynJVavSQRCX_asVuuZLXRBZM711_ohCbqOLV9uxtERVcrtaQXJAQoiUsc4gqGARkGgD48i6TB8LOsJkUtF1BZ5ok7Is0p12pOyrBubTZrx_6gKd3agjer0CUgbjPKQZB4DSnjAvOkShTrkeeCSrGqB82PMmXlUDzyOUtUjBqBZUqluoY_Axysq1tMAWT_8CKn1A3N3DZFw1QNUdUqUf9iPIvcoe2d2s_uJJnAJHBlP5KiQMWylGojvB_HPmBPFbOpa2oVc98NSSWfbKnVkOQ5lZXVzMqRD3NbEFUyyrJcDRmuf2j7Tmc4TMB9mRX9JhtK3fjkCBWzxncYfkLqI3_IMdTJvfZDCuOcz1FXArJcwnhEN-fOI415imLScc05KWJ9YffET0vktGVsa3VcJ4QMxweg60s7Js2mgMJe1Hr9IjGv31qpS9RbI7_MsYamkHG5pjRrW63jWq4pWdxWdFOEkWNIlqFW68MF15DrFb2ecok2xKYc89qonjp8Et7PBmOXeEUxsqEqTRgy_XXtaSNeahG8AN4yZNloVuayjmvUvjXt_JKPR2qpltepEkn2f9oRP7MoqijXq4wxNNTWKQHnHVgcMhdUVA-lizB4wMDIW5OvE06ChJvvZb22HYy8ERxkkyMLCy-JkwxLs3FllJeHeHseRLTzMZ6ykg0q6nnLeCur2olje_jYC5x70pSFFrIWR7l-g2Q6haGORtFUAE76EIO4nA9X7ZoUxOdg0vzwFuucgzn5HyVpNXXjAnKXZ74VRkOO5k1Bf2WulGpXlqNuXELem6cAGRMAarqOcRpwbsW2LFYaax_izlJcCHGXvG0qhqyrVrU-KFuTQDeVP3h0PU-I8O-FHYKALSGC8Tsk9Im53UMigMfvPpIVYXdzkVdkMiVRLOyBnXPBpQQ1tWRLFnUr99FWC-Xrx8TvoWy20iBsEPJfBE_Qx2NcYosKh78JNTjAqxn6IfFfZvPyxUbkfAE107cDrjQgRuMy5jmWFbOXjEaRMAwmd3Z8AgMBWijQtgt5MXdAwrJYkgP9Yo9GbaFLuQTWlLZwCL6y5wjBSIC-439ejRPfIWFbKPoUnn2frqrAI283beGr6ztCD6sN0xNEDxFhhacVvnInMEtGUc-ObeGBPBHvajYlRw5d-nTS0O_GDl3bj2WaSInYIimSKbKhK2BTxA6HYxTdtz3vDuYBan15KrNFZOq7XkzCHqRhpVDf8-VItByI3n8kJAzCokJY5d0duiSMT0eTaRDGAnnG_9DgZ5-3RrYXEUZIU0B2FLs-XW6CGQpH0mAcPHWcn1j6VRB4UcYk2NMp8Z2SjKuQEMHO5psh-jJUbfhDmNgRtGTGMCzCFnJr0akK_QAqgJ6DYShtzVRkq62Kom62VU3R25phylJbUVVTaSuyBH8lw2zLqinJbUVXDQvyZEVpgz9tGG1ZswyprcqmZrQlWdZAoA5xdVs2RVUFelkBWdgdbUmVdbktA5feBgdJAukGwAX8leBZ0lURnnUDytIlXZHbqqpaIjxLlg40mqS2DRn4dQUkqpIoQXmSZpltiMR1yNNArKQastbWZctUodKKDgVB6EsrplpAbilmW4Ncsa2JuqJBEboMKTq0u21qutXWAFxMILdAjKxKuta2LEttQ9stpFN0ETQloVxNVVTaJJRu6FglE9UhKQrmajJQyoYm0noYbU2RsAYWNgFUCHWFuQASoJGgcclQJWAFNUB94FG1ZORXNQkyNVB3G3RqoizAv7aCReiKhDqSFewPyYKCFFmHvpItBSojScAAfWBiI6EJIEY3VagqTEJm29Chg3XoWWiBbojQVNGE8kCbBtUJdryoS6BJ1RAh3bQMEK-Y0G5JBBMAraqQK1miCHqDGaWtQ3tBTQpoU1d1SFBgmgE9QCOhvtDjGvyVTRx8uABmh7NO2Sp9FwZBDIY992Yky9eoif-2e315Qh9-G8fxNPq0s_P09LQ9teNxMCLP4CFvA8ztTIEJBsdHOul8RKk7Hfi3d3-9Z9_pfdWaDMd7B6rqyAeRIiudkz_vjSPtdnw3UQdfb16m8uNPxQnju--zs7Fya5wZf_047rva40vy5eN15_JBD5-ejpVj42k2cO9PBn_Fyf35QDr3956cSW_St-7HPcl7ejixHpMgMsTnYZLcnM36R9_84PHhT-vb5Kt5GT8F_vlfD18fiHHqTB68m7Pv343u5Pbx4tuLJp11wzjYl0z1Lgqc7v6hRIZ7-yG5-n6SPHe-RJ2z7oU9nH6PzRf_YzgM9-Obw-7Dk_hCeuKZeDj89uw-9veub758_Esh325Pno8Pgsvj48PnO0cMjEPz9mO81wtuj84Pegf9j6O969Nz0A9V8E6m4V0Gp9EO-4XeU-gCbjD174JfHbp3SUyyDAC157MUWKhVMmBhlpjZICIDwxc2rpnlU7PeElw_PuORiY7IFDXoWEzRiJoss3mGA2xA0aGFFshGJYOndEDTYcbgidkkG63UMtH3CNOC6WDbSpu8U2rz7g7iax3Qxm7sFa_6hPNp7E7cF1wgaATBCqhFSwGEA2IYuNACHo51yYJ0wAM9xU4em3VQFwxQXYTBneI0QLFWQmgYnEBDkQ0dwTJii5oup7jNQIehN4O0RfRm4LeI3qzHShgOAMA6ieIi6wcewhnssg5fxHAGLhRnGKRS4OFQO50Z6ETGoJ6HbR6wU_iiUMbPGxTt0vlhNV4zAOUBm-Iqg9hapGbAziM1Q2c2Shhqp2jOpkY0-EV0ViAIKYFzOiuyyY6CM5vmqEVRg-fBWULjycAZ59d_PzrfhRSdby6ls-_7dw9jxVEPxuGZFd8ejvcj-8vHr73owb8Vg4OvM0Br_8x2pieWfNDvnpzKiRQ_HDruw_dR9OXw1vhu7KWoHT3LGWr3NQ_g8mev86R24uPJ7aT_8eRaHx72_rTOjDu5u3_x9Vv39It-oYtfrOHoZdbX9D__nMjabP_kxzFF7e9SoEBRyvEhQ_vbk5dz6_Sjc_Xlh2HvnY3OD4zjw9HBsfXN71zuKf0vymX3qSMeWdOZ5yov5xC7z6KBdK3c3_auALVHenT05bq_dzFxFO9p1huMf-wPfnS0E8s7Pje_nXRuug_eaNYb3z9JD8rTzWMQgLY-f_6FaM2Ah1kjj9MMJ1ajNbMphgCpi0RNmNkgj9kpCDC_kY5iNkLYOKNDHkcgxT0ep1dA9O4O-sj4cBbELA8Tsx-7NCaNwPcP4wMyifZmEGv2cRGSi95TBxspBySmoF2iz7ZnOGRkJx6mf0lsz0V_X-RTT9g2kfIeD5AFDj8uFDGRGE5AszonJ6krnxYruHS6SLuYRtK4HaRT1K1re8OI1s71h17ikCM_bUJWQc--wwrg7hZ8z-Fk6ZEX4Nt5Yk8DX5C25gXn5f62CxWk4SZU6AiivOcUEJi8Ay-4sz05L401V9LL-VKW_5OFU4gaECrm0T-WWEpjke6W8CNTqgxavScTJDolse1AbLhzFENv7GCX7NA6wxMn1LcnaYDELzTMaWEYJH7au1wLU61iM3deoYTVOuhTL4ItUqbmwGkjTeGJFvSyQi25iZ1C5OnaHgbiAa-bNF1IM96WerqBj29KQjsmDvO0KpW0SLqxqhZF8Qrjc4Us-22p7ZCMqhWFmWuphtMM8vK6YL_fVuNhsO-5Malsf5q_sXWk_PP4wtI2U8Uug69fAvN_O6ynS31shThXPpe6HrTnyF6SW-i-vCL9tkwRXz_2sQq4hbPKHnmijY2yH_hxMGIvRQvdYCquzrL0NwbtXhARtrxcjekFzeZgXsgooTgmC1n6G0MwfxgSGxfFJ261ckpUG6vnnG5_SSDqoy8qCwXNZfw7gC1dAn8zyJa-G6GvRrj-4JMX-kFr5LWWJXNWyr-NeXMjeMxeVwzGQY3zWqJ6jUuWbzIouWJ56tvSDY6eIe28SsUUJK8avEzE_MjNUt-WVvJ3_vvP0yBKwmrlLFBurKMFSbyq8kyhyP2PRzptdUcdjAM89EGRP--aInHdzkhRjpda9AFNFXqvmWZ-mb3iS-gkpC9qF011Se7m_huE-P0gfLJDp-TAQbKQp79bJkacuOXgfHRUMk0udUPbLMnlA1xuw8Nb9ROdDvx3PlqxQLKU-hXLSfe-O3KXLZDkWW90daTjOMTJkZ_tYazU2jLi189FR_4oieacmWIuKnLfmr2l-3lqbCyl2HSBKRdQWl4pEt_a6m24IoLNKTa3mcC_j8ZBaYQVaf_xU4LafEpI96AtmRbSnFdODbn8ZdNDnvkGsQ738zaBuYLuFXEanhtYBDdMf7O41pncJdG4Wjc0e2OVMHZeGVnK29LCgWcP3QpXN2tNTrKxNgoRpRiAS32HNHa-2I7Zrlt-pYlLXnOGzRaaSoL58cnt831rlpke2M_2OFea5xzdxjZ6EQaLCMYlvlsonur3nWwHd94PReJm1skLLTRf2i3-tixzz4O6Vdojzd3YCik3r4c04Y0tArNbFtjuiupFYJ5q09igJKQEXizjjW7xOLXdSTVkQeYrYnB3Ug688fc7OoE_EbqTPrEjXuN52mbYxInk_BZIFNLUV-s9fQTS8h6wdF8xKnGLbgiT00MnbBsbPlKxlOvInyYxrSFwuNHwFo_24FVBdPscvdtov9_f714d3eynx214FqqtWz-Z3FEMpv8X5zkHhL5sEaLkLmKPn7duXPJEK9ID3blehC33PHsakfzUCq102hwPF4SqpVGqQze_cGi5rIKgWtL-MwljaO9XOxyGLqmsV56_olKsQDxEjMeTqqThHT7VgtgWri6YCzvkXKEpem1StRS8w6iyOZhZw3s0mdpeZclp7gpNxLhZEczfHblDPIpW3-W4tZFR1eglv0Kisr_Tk7TVMuilSFUCWGY1M7ufqIo7za3RKj2xWKlVllvN3iNDu7LtLLOaOT83H_iHeIHBcik5VY2ks8CnRg6DpuN6ePC1smf3PZKTVAs8j8ckTA9IVEk6BYzKSGoHDtu_XCmHo6jRFb19pEJDmFfNyu7VqGgD5tUMmvRqiarR7tYP2fIlEBX9wdNUi2IHoSt1mJ6qrumG9EaBii5guTUtya5WqGhEml0zUCgGd34GbrorpWLIzJHVgUYwfHy9GHpZwOvFzN8e8HqJfc-OHiv7O82tZr-OXfSQlkhhPk4jITiwXicBx9frJOCKwGRj7st5V6Tgvax3QvID1kuZs9y6sZ8e795YQraisyE7PSe-MTedAHpkRKAFtTNATlMzOOLEz962v1IUrdZyFClat5YsNhcubenaEtnoTu_hqgMARrJCEEzmhzXuYjNJ-Y0Yh8T28DbHwHudwIX7xl4jDO_2Saa272Tizpc56UU_NNReEEcgkx7s7-EVQq_VoU8msyWCquu1u5OFdfTIPwZa6eUFgzjEKPslCCbf8U4PXdyWVU2VTEm2DJaeHjuS5PSoEXjgPRe6MaTmlxWLlN_wLhhVs7ZFVbUsw8iuBdmlMXB6Dgqf82NQ1fKSiLArDtmxIsrBNMUiTZDCH2m6hIg9nn0SLjuX-629MAgcoRvOWulFCI6wZ4cQmoXCl8QOYxJGuAuyRYXQ5n0SdKuVnrr6JMhiKz0E90kYCIPWZeKTT8JRCP2Ajwu_qYhL8gOkyC2IfDx36CKv3PoHtAnCjfif_wiB8J-q-DsuebDNE0J295HAuqv1QVJ-F-JAoK4EXuULNW_hFT0pwSdBkT9qZgsDM8oHViqwaOaTIInbovh7i8WFkTCFtjL9Qda2ZrTM2qI7jhMJsoSlK9LyXEXGXM0UuBq1JJmXygoXaNTZonECiQRtW9Z-x_eac1IFOxJwOm5hLCEo9JlWm5q3cAwBH0jpBmGYTGN4whWO08C5tH3gDfHv5y1xW9tKrSBdA6mkkFdS6CspjJUU5koKayVFdkFxHUm2jEJXl8oDQi4PiOuzoy_X-2AXLxAc_BcMpei_I6HnRg5ovXWA71K7bjj0SNxinr_AXP9PgiGWx4dZMT7S0cDeu3nzA0IV-QEhzQ-ID2hAYFb0pS4LGqjVf1AtTJ4wcGd2Ihm8rbH20e1UFFxGQeI7LVmlppZaWIwAKNzN8JwwWGKpgczsZJ3Sp5OIgA4m2uX-cxzaeWqZ75fbobKSQl1JoVXbh7IEMA9sj9ArfCatQQyRgx0KnUmCRsGbgKJzHSub5Y79oGOH2Z4nFPEzIhrfjajelsr3YinngyYvdPpysSY1mmKbE2c5xrbBupFe1keYl0dxhR1J_z_Vf_8KtFpmA-oyG_BgBhdOgmDaugqm9otwCZot9b-scf0vGXP9L1vVnUInEDq76ByBk47SIJ04oGOVRQuQxNXD_oNEzaRHnmFuh_zWB6O6Muq28m4hqyxEW2Yh4yDxhGM_GT56pHUB_qO3aCSazBmJMgcSJt-VuHid-gqFfchKvYGYKv2ZrvKCOeDCfEvSG9iIOWci2u8ZtOx79HI-nL1yM4GycHIACurvcPbzbh7IvMzrdidRHPgEZsowSJzW_jMMqlj4aj9Dp_xpo8PQSlfmwE5Mdd7jkBWl7HLo_xKXXKv1QMouOVt4bAtpNQUI2-am_w8qtaOMIDXAD7LGA1eZRSpNeXWi9YXZUgIrDfFWVOZesxkQrPFHAlZJV80B_OSyZUv18PY3utRvzJJXO-7LbN1YYuvdsTsBZQ-FQ3BciyjzwE5eiPA1hICcs3RlwdDLrjUQ1LrWPbzsOV7wrLVGnvU8erFYjk3F8xEZB7QsIMQUVV6ByMai0yZRlD7y0Zd07wn16OWaKZnGihApmno5UkwDyrmA8R2A0V6rlj1OiH2fkMImB64HIbnnTgEConlLNLUy4iobBXmatlGQJ5egN7siN3UJ0J3kQLMElEoDUFSWm_8HWao2ww8q9UFwfVi4GockGgfeuzvIVi0Wza0fEAgXho-tU9v18NKEuEVDSDC2gNlBCeRMHrvUssHgDJl1KH2Hkt0ni8uAMDFaFGPY5NySFd4yGDldPMpuZhfwQpUWrjpxziatGVt9FrLFf7AGcbmVsFiGXvlcDh2099Bhla1IYtlYTjsHR93WXnJ3R7fWXYEoeiccjnWqTNaFgPvxGCZP1yFlw1FLmMShTmlpSWyl3R8JpioywfhTUNN10AgcHz9KJmBUkoilWUpuZdCJYGitbhKGUCtvJoxhrinyW4pI56XcwOwpfvQLjyGgYQADXXgqWxvy_bpVHEmqVfK1F7sTGAVsYJQUfOo-B15wDyZdUrMhVqhZr1KzophMPFWzsqhmA4s0tHotF_lNtCwVOJFJxdGHYn-hruVluu74tjeL4mxJdQC1HSOMMKRJlX3hQUvdUeKVp1nOpHlVy3Pz6DXa0tOY-MIsSOhqJptDUy9sFAYTwca3AK0TiKUjQVvsA5WauiSt6AWOYA44c6xU17fwTWEEtypWv_8p32QHc43gAs_F3fXlCb7KYrsPDzywoWiLZh3xEUAVQ3F7XcYirWJhw4rnyFfuswvEgZ5e0Iq59JbPjPdPvGZcSJN42SvKZMuyRZHKKgZmjkrBITbj4JslN9OEzLFIDfUtr1ExdDEKcqtpjwqDJ_xWQ-NicEmLr5e2sl6BMxOyDU0Zl95UAZXVW2JC9O7esgmlSctMaJkN4g2yczbIktawQaogzj7UZha1TlcfEm_Cm7lcqxV2R39JKyxpjUbtBUHM4UVpPSDbR90Am5bssF4PqMT1gUpcG6j-fpwS_wacEteGKfGXo5T4d6GUuBFKif9_UEr89Sgl_t0oJS5DKQiwHMAn3N3zleAyR5TKxG-9PNEUPN5IP1Qt5idt8AAO-1BO-dtDOxXM4MIVzPmuLrolhW3qmvtoZlrRpZVj9WfHTwJ_5N6nW4XYj3SzEOXPUzKg7bHbkctOIX8M5UdCorgzjOVumBDvxvY8Msu88ysX4oqoOM4ilTzfNNBPgxHqbPP7O8vF4Gzgop9Md690x3T3ypZwB6ogtp9uatqprp5yFoQT27uCWt0QH4rqhrNpzNWt7JWn6x3cIgQ9BlJXAG1_tfwPkrh0zaNOpswqvY5Syws1K5QK82z5O0wr1VnuBnpRXGU3XHj2kOAKHwSQjJtQJvap8ezAkiGKKxhKnxHL2FYxzd0Dwx2QEmV5VYHcd8ozNm0FD_9ZuJxnZcvyWxzWqh-WtQFbep15xmGq1fST_Lvr-ElwEtL7DoePXTwoNyDeiCtXa9DGtRWT994F7jjN2JSmXOt3BJrYvEpV0VrBlp-SyHVap1TKUv4e49pmiazgMjz6JIpol0SFCLmJuTVVKLspcq4EqYZ-GNDdro0ZaI3Sr1IGnkeXL3hUWMGZOVp5SbJpiQ0UOK93pYYpcu9d73xEIRJaRhGyactwjDbVNZ3NKlS3u5NPycsn6MVI6B1333H3HXffcfcdd_9luJv9-qO1u3Nhx-PzET1sAiYv_9H6X6pOPhg=

I copied from the original issue.

Before screenshot:

image

After screenshot:

image

Reservation should be rounded up
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Feb 7, 2025
@LocalIdentity LocalIdentity merged commit 6c4fe0e into PathOfBuildingCommunity:dev Feb 7, 2025
1 of 2 checks passed
@nessgor nessgor deleted the incorrect-rounding-of-unreserved-spirit-when-activating-heralds branch February 7, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect rounding of unreserved spirit when activating heralds

2 participants