Add support for "against enemies within/further than" #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
A few tree nodes like "Death from Afar" and "Stand and Deliver" activate based on distance from the enemy. This has those nodes and the smaller nodes work. There is a pierce mod worder "Close Confines" that has slightly different wording again, but I didn't touch that as pierce chance hasn't been implemented yet.
I can't figure out how to get the config for enemy distance to show up using ifTagType OR ifMult, I can only get it to work as AND. So for now I removed the ifTagType, so that enemyDistance config is always visible. Which I don't think is a bad thing, as eventually accuracy needs to be properly implemented for PoB2, because by default there is accuracy dropoff by distance as a mechanic.
Also, not sure if an enemy being at exactly 2m should count as within 2m. Same as further than 6m, does 6m count as further than? Or does it need to be 61. It's currently coded for the exact number, but can easily add or subtract 1. My concern is if at some point down the road, there is something like "
20% inc damage against enemies within 3m" and "20% inc damage against enemies further than 3m", would being at exactly 3m count as both?Setting as draft for now
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/ju5v605j
Before screenshot:
After screenshot: