Skip to content

Conversation

@Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 8, 2025

Closes #646

Description of the problem being solved:

Due to changes in how gems work in POE2 the blasphemy gem was turned into an active two part skill with the active part reserving spirit. This caused the actual spirit reservation amount to move from the support ffect to the active effect breaking current blasphemy handling logic.

This pr makes the part reserve the given amount of spirit multiplied by the amount of supported curses. Additionally adds parsing for the less reservation of spirit mod found on the Matsya unique item.

Steps taken to verify a working solution:

  • Test with multiple curses
  • Test skill group tooltip
  • Test reservation scaling

Link to a build that showcases this PR:

eNrdG2tv2zjyc_MrBAN7aLGX-JG4TXLOLhw7aQIkrWsn7d2ngpFomxdKdCUqiXex__1mSOph15QpBwccrh9aWZz3cIYzQ7X3-0vIvScaJ0xEZ432Qavh0cgXAYtmZ437u8v948bvv-31RkTOP0_PU8ZxpfPb3pue-uFx-kT5WaPT8HxOkuQTCelZY0yiGY0bHkl8GgWDYuGTiGjDkySeUfk1Y9r63gbsOYmJL2l8gwT7qRS3IgCMKeEJoISERRPhP1L5MRbpAiRteE-MPmug69vR5_FdA6R60xtxsqTxRBLpJfDXWaMP2pEZvWISUAhPAb7VaFbCnqdxIockhMftOJMFpcF2sEHM5G3KJVtwhrYx8B0bPMg7mJPILyRot6zE74QkfDiabBdDQwoHW3xjcn7OQTcnugh9PYuYpM7gI8ESEdWS2gl4kHIOm9QJdkwTGj8RyRwFGYjwgUWONrklERmIRLpBjmgM0SJrIUyoLyDA6vKoiXnDptQdspYeBqGuNLvpcTFxhatNeDeBxpBg3CAnIuWOkLJILh9sQEP6UqSVrj04fpQBOy0r5HUktzMFcmW4CnJD-iQwJB0Tw8XVKId83z446Rwft04-dLuHh1ZZRvNlwnzCb8kLC9MQku0deaQFw-OK7Tebywjyiw21a2V6yWJaH2sgeLAD1pyIZBftptQBDM48_xRhryO_AK8ieh_FKtWWjspqKcYQR3gaP3DqiFGwMNHocnJqVjMaGX5LtwR0Q6k__whFyZhI6pZ7C6d1Ks2KsGWzVhLdYFY7-VWEGkZCxM1G6hwcVyHVNNNkwWLmJJGG3KB9p-uKsq6_HfMiovFsOZkzyh0KvTJ0Zq8BWTgVkv5pGdtpF6yyq7WRy6g1PYUnV11uTyQp5_TDw2pDaHC3SKBQpwJCQNdKZivGKBb_pr5kvB5aPw5FGju6UgM7KZAdR7rnGNMg9d3Ov4vpFNV4ouccuiNXNXIskJPzWqh9KYn_OBTBzNloikktjFX5JuliAUGLu8GVAJ60UNqzUsG0f-QA_Rm2slOs4qHszqCAdmaQlxnuXNZQ3HXBUmGNjQuwM4PcnbeQKkLIuaplhta9yPRW10Av59RrKUDHBnEknkHyOU4hknrQUFAV-csqSkyjP5bO9FfAnRhcREEaYyA481jH2MTmPJ1OE8-HBpfIG3DvWaPhPcA7_dzn_pyG8Jh45wIzk5_GCdVrQ5osCIv_7l1yEobkgXEml4bqHQshOSfJkEjiBaau_0piRiLZUWOchJLYnyOlS8L5A2QX5Fy8Vb_U6OeScUnjIbxDVVDddYrtbCv1mmo8hU_X4ULE0qMv-M-IxHKZTZUUoHoDdBLJIjUHQF15w5vMxXM_eEJOd0LwJB9FkcWCRsEKjbuYUo9kGctHIZTy-MMLSQJSL3UQJKhNaSx2HSg1IgECQOnWOuqeoO7YQpJ42V8FjBjIJYHX2uisIIRc3_Tuxzfq4c1cykVy2mw-Pz8fLIiciyl9gSPvAJzcXAASyLufPDLO95Fqsw9_zmd99UcRamaUenr2ljT1L4z8mIHImk0PDoWYPaSSZgtgz5dPWqeGxyKZPycyzp4NreYKsV4TbaYciEbFh09C6jV8mf3oTVDsBDZGLD_SMDlfQuRfYiGzNqMxXkHoCZV6w5VxzhoyTilupClJOb7_khLcv2Z7ZW9v9JwzEnGYd41ACjYJHk-a4t1ygZr1b26M-w1XjwXZljAv1TyzX4g2INxPlHAs8nkaQF9lMl--7Th5QAFwPIs9UZAJvkYpZ_SmBxKp8AcJriNwiNlAGv8jFw-EdzIq2Ri3tbreztafdHzhLjuH7baAXAAln9o7K-905ml4P0pGnNEQYW6pJAFkgea1BOM30QNNJTI8lWhGJDRBVHq5prMv0sj4sqSfMSIq2fzvmsAkvJIBzJsd1c_pFcrnr_7HVF9J8YX-5dc7GmGVcmGJ1fe7maOnufyfRGBxFuujOPfC6kItP-RuWCdeOCJf-RtZiOQfWSHwao-YRwBVeV9ndnxUSAriOlqkUoly1gAJ_O9YmODdjzpR1F3VxeXlxeDu-uuFKTzKKMpA36M0fEB76H-LonNCVbPlJelDoh_PGl8ZfVaCDMFSjCeoF-dkkdD85FdZ3UjOAa-CmoK6YvmV0mZaBYCd0sULjaFQmX2D6ihm1CpXvr5FKM0QO3gs1GzU8L7ITki3hAMoc_TswGIpdU1mp4L3Y1Z1cLECF0o8wq2czeoWS0g8vGGfsynzsXKudjke9Rqqwi4-1MjEX1b42_SzdhrqAs5GQC_akfUFmw3brFZYVV3nWa2qV-3oQ-oTq-560Y6cj6NEpC5uN1PJoSoofRKR2uQQNH3Gsfu0evaC0xzETvCznNPYVPM2SreQozKQysDRZbOVTgmiwlZqZm-xEK7ZUfVc2qIDrlUEjZnV2qKdVYfs6kzV4o8yjJ2UnkZYbWgmGxVuMEM9iwv0aoUm2VzTooRZrggUlYP7T4IFerplCZk1sKqkAd3a68mokd3ryazP8F5PESrC5NHqb7NqR7-XqpbcQEVXME5EMLBeRwHj63UUcJgT7ow9Xi9FCtxxdRGSj502ImerVbFvplE7U9Azs53R1UhvZ2x1AAzplIIGlSdADlMRHDKNhmAMWREYjqSUWJuzSKFdLVr6LNyoaW2KOrrNNXRVAtAgWwjBYX5VUS66UcrH0leUcPwcSfDXEfzpuv01xPBiLV2QKMjIfd5UpBd-cLSekAnQVMPRId7fvdaGEQ2XGwjZ5eo1s7ZOjU2x0TLD3omMsbv-Q4jwX9AIH-lHM3g7NMM2qLmHDBwXqw2XMULAf5419g_1bXRPtbVm9ofP-ejPTiJNqP505xuF9jZSGNocup0EKlkPrj53LM30xvBaLk-9-0_XX-4v9m6hLViSvQGcd3jB7H1JSSxpDO3wdLpnBtWn3iimXuugfdAuXg3SGGSSe7qfpIGXr3T2zFQSHlt7yiRj-kP9gO6GMx-C4dRr7f1pJDzt_PVnjB9hnrYOun_1gyDx3r7fP3nnSeG9bbf22913Hl5Kedo7VXhtjXOy3wH0_IopRyygf317uN999wuCY7uG15ke7F1P9zhlyLft7n6nBaAs8mNKYMN4uof0VJO4Atrp7h-tguK56am7Z6rzpodt554ZCJvbfa_b-sXDewdPV6Jq5HArAvVlqqfonzWAQeZHM5SwQnS2QhxuhTjaCtHdCvHexKIa3OQbE2fM9v27On7mQnrQuIWjh_vxDcabHpF85OIJczwu6buEZjWCZuO1C5T2NhRVkpQxtjLphymnsgaCKom8w9oYdYTSanTq26oOyjnlcgdveJNnvJF1xhtjLNeSSwRLL-uYahtgJ_Hatb1ZR6ErClWOrGUBIX8OFB2ReoaJJxsJIBzxVPtGMWcm-uhT55IabYpoymbmhNI_zBml8PM3nmSSU5yXqIuo1VgeceLTOaRxGhvZKB7H5oP0bMz5oZWrZEFY-QAgQ9uGlB8F2VAzH6u2Op1tDOPi4_YMrbsFp_xJR46zVTN4s4N8yGsHNHUuFxjHR3b4MP-fAPglPJQiwUQNUXF4Dsf_tMS366BjbcPk3hthnZqhHbpi1eaXD0ly41RZp9iV6144ap3Y0RI2Y_zzVHV3YE7Voq4N-yutWMsWq59s1d7-iApZ8TGCGkW5viRrp-W0cXDEv7yHkghaBSgb-dJJ28lc-I_rHKvgfaFqc2cEpaL5kA0aAlXHlLPRFszsbMk5dY5PnOyBrXRU0xi5O9a9eNhySBGu-2Uwx0uizRaEdijL9bo5Ur9-2-s1f_ovV_8Baol8TQ==

Before screenshot:

obraz

After screenshot:

obraz

@Paliak Paliak added the enhancement New feature, calculation, or mod label Feb 8, 2025
@LocalIdentity LocalIdentity changed the title Fix blasphemy not reserving spirit Fix Blasphemy not reserving Spirit Feb 8, 2025
@LocalIdentity LocalIdentity merged commit 1eef33a into PathOfBuildingCommunity:dev Feb 8, 2025
2 checks passed
@Paliak Paliak deleted the issue-646 branch February 8, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blasphemy spirit cost is not calculated

2 participants