Fix duplicate skill for Greater Lightning Bolt and Decompose #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Modcache.lua is not where changes are made, it's auto generated so this code will get overwritten. It needs to be fixed possibly in ModParser.lua. |
LocalIdentity
requested changes
Feb 12, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
This is not how you fix the issue. You'd need to add parsing for the "on Step" and "on critical hit" lines on the items so that they don't grant a skill
LocalIdentity
changed the title
LocalIdentity
approved these changes
Feb 12, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
I fixed the parsing by removing the lines in ModParser that were parsing these lines and granting the extra skill.
The lines were carried across from PoE 1 and are no longer needed for PoE 2
Blitz54
pushed a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
…uildingCommunity#763) * fix for duplicate unique skill row * Fix parsing --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Blitz54
pushed a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
…uildingCommunity#763) * fix for duplicate unique skill row * Fix parsing --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Blitz54
pushed a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
…uildingCommunity#763) * fix for duplicate unique skill row * Fix parsing --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #762
Remove the duplicated skill rows, support gem adds their effect correctly.
Trigger skill entries have been modified to match those from other similar uniques (Earthbound and Dusk Vigil)