Fix warcry speed scaled by cast speed instead of warcry speed #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531 .
Description of the problem being solved:
The cast time for warcries seem to be correct in the Tree tab (deriving from output.WarcryCastTime), but the dps is derived from generic speed that is related to cast speed
Steps taken to verify a working solution:
select cast speed or warcry speed in test build tree and now dps only scale with warcry speed
IMPORTANT: "99999% increased warcry cooldown recovery rate" is necessary otherwise the long cooldown will "hide" the dps change related to cast/warcry speed
Link to a build that showcases this PR:
test build