Skip to content

Conversation

@Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Mar 9, 2025

Description of the problem being solved:

Saffel's Frame disables the ability to block, and makes any modifiers to max block instead apply to max resistances. I believe this functions as it should, but please let me know if I there's a better way to do it.

Steps taken to verify a working solution:

  • Equipping the shield disables block, and prevents any + max block mods from items like The Anvil from applying to max block.
  • +5 max block Anvil applies +5 to all resists, including chaos.
  • A modified -5 to max block Anvil lowers max res of all resists by 5.
  • Melding of the Flesh isn't in PoE2, but regardless we don't need to add the max block calculation there as it affects all resistances equally.

Issue

Modifiers do not show up in the breakdown for Max Res. Not sure how to get them to show up. Would be nice to see, but not necessarily needed.
Also had to hardcode the 75 base max block chance. Probably no issue, but it would be nice to grab it from CalcSetup, not sure how or if it's even worth it though.

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/0gag30n0

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Mar 10, 2025
@LocalIdentity LocalIdentity merged commit c148c31 into PathOfBuildingCommunity:dev Mar 10, 2025
2 checks passed
@Blitz54 Blitz54 deleted the saffells-frame branch March 10, 2025 13:59
@Blitz54 Blitz54 changed the title Add support for Saffel's Frame "max block mods apply to max resist" Add support for Saffell's Frame "max block mods apply to max resist" Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants