Rerun Node search when switching class #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Mar 31, 2025
LocalIdentity
merged commit 96f5f9a
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #849
Description of the problem being solved:
PoE2 has different starting trees for each class. Currently just Witch changes the tree, but eventually the other classes (ones not released yet) will too. If the search bar was looking for "minion" as a Sorceress, and the class was switched to Witch, the nodes by the start would not get highlighted. Somewhat minor of an issue as you could backspace one letter to refresh the search, but worth fixing so that it is automated I think.
After screenshot:
Minion nodes that otherwise would not be highlighted upon switching classes.
