Fix Burden of Shadows Life cost calculation #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mod from Burden of Shadows internally uses a value of 100 for the stat `base_skill_cost_life_instead_of_mana_%` which also comes from Blood Magic, Lifetap and tree mods. Talked to GGG and confirmed that all these mods should cap at a total summed value of 100 as you cannot over convert your skill cost The game will probably fix this issue in the 0.2 patch later this week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mod from Burden of Shadows internally uses a value of 100 for the stat
base_skill_cost_life_instead_of_mana_%which also comes from Blood Magic, Lifetap and tree mods.Talked to GGG and confirmed that all these mods should cap at a total summed value of 100 as you cannot over convert your skill cost
The game will probably fix this issue in the 0.2 patch later this week
Fixes #477