Skip to content

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Apr 4, 2025

Description of the problem being solved:

  • Add support for "Critical Strike" (Amazon Ascendancy Notable)
    • Chance to hit with Attacks can exceed 100%
    • Gain additional Critical Hit Chance equal to 25% of excess chance to hit with Attacks

Steps taken to verify a working solution:

  • Mod gets parsed correctly
  • Only applies to attacks
  • Values for mainhand and offhand are calculated separately
  • Works with different weapon types, including unarmed
  • Uncapped hit chance is only displayed if above 100%
  • Works with "Hits can't be evaded"

Limitations:

  • It's currently possible to benefit from the mod twice if you also enter it manually in the config, but that's basically deliberate user interference. Might have to look at it again if we ever get the same mod on an item.
  • Impact of distance on accuracy is not yet accounted for in PoB calculation (out of scope for this PR), so added crit chance will be overestimated for ranged attacks

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/7l6ey00t

After screenshot:

image
image
image
image

@majochem majochem marked this pull request as ready for review April 4, 2025 15:23
@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 4, 2025
@Wires77 Wires77 merged commit 083e82b into PathOfBuildingCommunity:dev Apr 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants