Add new Uniques #881
Merged
Add new Uniques #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 6, 2025
LocalIdentity
merged commit c090ed8
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Separate PR from updating the old uniques. I am not totally sure on all of the mods. Example, Blood Price stun threshold. The last 2 mods in ModExclusiveItem have the exact same stats, so not sure which belongs to which unique.
EDIT: Also didn't parse the new mods yet, first goal is to just get them in PoB then tackle the new mods.
EDIT2: Calgyra's Arc has different requirements on POE2DB than it does in PoB. I can set the level requirement to overwrite to the POEDB level, but I cannot get Dex to overwrite like in PoB1 examples that I looked at. For now, I left the Reqs alone. In shield.lua with the bases, we have 3 copies of Ornate Buckler, one has the expected values, the other two have the incorrect values. On POEDB, there are actually 2 copies of Ornate Buckler. Probably not intentional, but because of this we grab the higher Requirement shield.
Sunsplinter is a little weird. Not sure if I can assign only certain mods to each drop down for variant. Don't see other examples of that.