Skeletal Warriors for Sceptres #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blitz54
commented
Apr 8, 2025
LocalIdentity
approved these changes
Apr 8, 2025
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Skeletal Warriors are still in game, but only on Sceptres.
I implemented the 2 free Warriors in the way I figured was simplest. This way the uniques that count total undead minions shouldn't be affected when they are implemented.edit: Updated to use the stat on the gem instead of hardcoding to warriors (LocalIdentity)
Issue that I haven't solved yet. Rattling Sceptres on trade say
Grants Skill: Level 18 Skeletal Warrior Minionbut from our export, we only getGrants Skill: Level 18 Skeletal Warrior. Probably not too hard to fix, I just haven't figured it out yet.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/vqei400y