Fix "Could not generate search" error when using only full dps as a weight and not using full dps #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
force-pushed
the
trader-fulldps-issue
branch
from
021eb20 to
7ede00b
Compare
Paliak
added
pob1
LocalIdentity
approved these changes
Apr 9, 2025
2 tasks
2 tasks
|
is there a way to download the pre release fixed version? :) |
Contributor
|
@drequeceler You'd have to setup a dev environment setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue mentioned on discord
Fixes #925
Description of the problem being solved:
#8247 removed handling for this case. My intention was to make it so that when fulldps is the only weight and it is not set then it is effectively ignored but that caused this issue. This pr re-adds the if check that handles this situation as before.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/AGQ1ldvG_rUz