Skip to content

Fix Giant's Blood Keystone #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix Giant's Blood Keystone #965

merged 2 commits into from
Apr 10, 2025

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Apr 10, 2025

Fixes #917 .

Description of the problem being solved:

  • Fixes Giant's Blood Keystone after wording change
  • Adds additional condition "UsingMartialWeapon" to CalcPerform for future use (not related to Giant's Blood)

Steps taken to verify a working solution:

  • Mod gets parsed again
  • Only applies to martial weapons (this was already the case before the wording change)

After screenshot:

image

@majochem majochem marked this pull request as ready for review April 10, 2025 09:47
@LocalIdentity LocalIdentity added the bug: accuracy Wording differences label Apr 10, 2025
@LocalIdentity LocalIdentity merged commit d211594 into PathOfBuildingCommunity:dev Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

bug: accuracy Wording differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Giant's Blood attribute multiplier mod

2 participants

@majochem @LocalIdentity