Skip to content

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Apr 11, 2025

Fixes #991

Description of the problem being solved:

  • Add support for "Crimson Assault" Keystone
    • "bleeding you inflict is aggravated"
    • "base bleeding duration is 1 second" (also supports ignite/poison variants)
  • Removed a tiny piece of unnecessary code for the Blood Mage Blood Barbs mod parsing. It was using function(num) ... return { } end without actually parsing any variable from the string

Steps taken to verify a working solution:

  • Bonus dmg from aggravate applies
  • Bleed duration is correctly affected
  • Works for Poison and Ignite
  • Works for numbers both lower and higher than original base duration
  • Doesn't crash for unknown ailments (it just won't parse)

After screenshot:

image

@majochem majochem marked this pull request as ready for review April 13, 2025 08:29
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Apr 14, 2025
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the mod to use a override so it works correctly with stack potential and the breakdowns look correct

@LocalIdentity LocalIdentity merged commit 9092924 into PathOfBuildingCommunity:dev Apr 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crimson Assault keystone missing calculation

2 participants